reflect url prefix fix #322
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I had deferred to the implementation on main here in place of my conflicting update, but it seems like that didn't work. Reusing the function from `handle` is what I had been using on the branch and seemed to work.
✅ Deploy Preview for projectsubstrate canceled.
|
mgood
commented
Jan 23, 2025
| @@ -327,7 +327,7 @@ systemd_reload() { | |||
| dst=$2 | |||
|
|
|||
| echo >&2 "staging ${SUBSTRATEOS_OVERLAY_IMAGE_DIR}$src" | |||
| (cd ${SUBSTRATEOS_OVERLAY_IMAGE_DIR}$src; find .) | |||
| (sudo cd ${SUBSTRATEOS_OVERLAY_IMAGE_DIR}$src; find .) | |||
There was a problem hiding this comment.
this was to fix a permission error on this line
There was a problem hiding this comment.
does sudo cd work? that seems like it would have no effect in a shell
| if err != nil { | ||
| return name, def | ||
| } | ||
| if !strings.HasPrefix(u, "//") { |
There was a problem hiding this comment.
@ajbouh not sure if you're relying on the // prefix here for other stuff. I think I had started with a similar implementation, but then found that the existing handle.EnsureRunHTTPRequestURLIncludesPrefix implementation already worked better here.
There was a problem hiding this comment.
I use it in aliases.go. I'm not sure if this has the right semantics for these other situations. Do you need this alternative?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had deferred to the implementation on main here
in place of my conflicting update, but it seems
like that didn't work. Reusing the function from
handleis what I had been using on the branchand seemed to work.