-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide packaging routines / CMake target #135
Open
nickelpro
wants to merge
6
commits into
albin-johansson:dev
Choose a base branch
from
nickelpro:vito-dev
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Default is shared linkage, also provide -static and -headers-only (bring your own SDL) targets. Also ditch the FindModules hanging out in the CMake folder. SDL ships with appropriate config mode module discovery and CMake ships with FindModules for SDL components.
Second commit differentiates targets:
|
This allows the "headers-only" target to be installed even if SDL wasn't found during configuration, enabling a "bring your own SDL" style of development for devs who vendor specific SDL versions or binaries in their codebase.
Third commit makes |
Fourth commit corrects a minor oversight about needing to link sdl2main Fifth commit contains changes necessary for CI to work:
|
* Update Ubuntu hosts before installing packages * Convert env paths to CMake native * Drop SDL versions which don't ship configs on Windows * Pass locally downloaded SDL packages to find_package(PATHS)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was trying to add centurion to my vcpkg registry and was somewhat surprised that it didn't generate INSTALL targets.
So this patch is a first pass at packaging centurion in the "modern" tradition.
Notes:
centurion::centurion
so that subproject/imported target usage is the samePossible Future Work:
set()
vars? They're considered an anti-pattern in some CMake circlesA working portfile using this patch is here (commit).
If you want to test this out, the following
vcpkg.json
will do it: