Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Metadata infrastructure #31

Merged
merged 45 commits into from
Mar 26, 2024
Merged

Added Metadata infrastructure #31

merged 45 commits into from
Mar 26, 2024

Conversation

alcides
Copy link
Owner

@alcides alcides commented Mar 2, 2024

Addresses #30.

How to implement:

  • Decorators need to accept a metadata dictionary, and return the new metadata dictionary.
  • When decorators are being applied for each function, the new metadata is passed to the next decorator.
  • Between function definitions, the metadata dictionary is also passed on to the next one.
  • Metadata needs to be passed on to the synthesis procedure.

@alcides alcides added the good first issue Good for newcomers label Mar 2, 2024
@alcides alcides linked an issue Mar 2, 2024 that may be closed by this pull request
@alcides alcides marked this pull request as draft March 2, 2024 15:46
@eduardo-imadeira eduardo-imadeira self-assigned this Mar 5, 2024
@alcides
Copy link
Owner Author

alcides commented Mar 7, 2024

@eduardo-imadeira What do we want to call "syn_ignore", now that the old "ignore" is remove?

hide/hiding?
ignore/ignoring?

@eduardo-imadeira
Copy link
Collaborator

@eduardo-imadeira What do we want to call "syn_ignore", now that the old "ignore" is remove?

hide/hiding? ignore/ignoring?

I like having the 'syn' as the prefix of the decorator. But 'hide' is probably a better name than 'ignore', and is also shorter

@alcides
Copy link
Owner Author

alcides commented Mar 7, 2024

But then it's inconsistent with minimize (syn_minimize) and the others in the family, no?

With namespaces, we could put them inside a module, and import the module on the top. But that's probably for after your thesis.

@alcides alcides marked this pull request as ready for review March 26, 2024 13:21
@alcides alcides merged commit bb87c65 into master Mar 26, 2024
5 checks passed
@alcides alcides deleted the metadata_in_decorators branch March 26, 2024 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Metadata in decorators
2 participants