-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: refinements to support client generator v3 #130
Merged
aorumbayev
merged 25 commits into
prerelease/ts-feature-parity
from
prerelease/typed_client_methods
Jan 22, 2025
Merged
refactor: refinements to support client generator v3 #130
aorumbayev
merged 25 commits into
prerelease/ts-feature-parity
from
prerelease/typed_client_methods
Jan 22, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… redefinition in client generator)
…return type turns into ABIValue
aorumbayev
force-pushed
the
prerelease/typed_client_methods
branch
from
January 18, 2025 01:14
80c9a9b
to
4b8467a
Compare
aorumbayev
force-pushed
the
prerelease/typed_client_methods
branch
from
January 18, 2025 18:02
0a5bb7c
to
5350426
Compare
neilcampbell
approved these changes
Jan 19, 2025
class AppClientMethodCallParams: | ||
method: str | ||
args: list[ABIValue | ABIStruct | AppMethodCallTransactionArgument | None] | None = None | ||
class BaseAppClientMethodCallParams(Generic[ArgsT, MethodT, OnCompleteT]): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If these aren't exported, should be prefix with _? Are we using this convention or no real point?
aorumbayev
force-pushed
the
prerelease/typed_client_methods
branch
from
January 19, 2025 14:35
d4e9c94
to
ae45db5
Compare
aorumbayev
force-pushed
the
prerelease/typed_client_methods
branch
from
January 20, 2025 00:15
51b9a8b
to
e04630a
Compare
aorumbayev
force-pushed
the
prerelease/typed_client_methods
branch
from
January 20, 2025 23:50
0d6f20d
to
9fd3d10
Compare
plus a fix for box decoding
aorumbayev
force-pushed
the
prerelease/typed_client_methods
branch
from
January 22, 2025 10:39
a22e479
to
dd56bcb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes