Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: refinements to support client generator v3 #130

Merged

Conversation

aorumbayev
Copy link
Contributor

@aorumbayev aorumbayev commented Jan 17, 2025

Proposed Changes

@aorumbayev aorumbayev force-pushed the prerelease/typed_client_methods branch from 80c9a9b to 4b8467a Compare January 18, 2025 01:14
@aorumbayev aorumbayev force-pushed the prerelease/typed_client_methods branch from 0a5bb7c to 5350426 Compare January 18, 2025 18:02
class AppClientMethodCallParams:
method: str
args: list[ABIValue | ABIStruct | AppMethodCallTransactionArgument | None] | None = None
class BaseAppClientMethodCallParams(Generic[ArgsT, MethodT, OnCompleteT]):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If these aren't exported, should be prefix with _? Are we using this convention or no real point?

@aorumbayev aorumbayev force-pushed the prerelease/typed_client_methods branch from d4e9c94 to ae45db5 Compare January 19, 2025 14:35
@aorumbayev aorumbayev force-pushed the prerelease/typed_client_methods branch from 51b9a8b to e04630a Compare January 20, 2025 00:15
@aorumbayev aorumbayev force-pushed the prerelease/typed_client_methods branch from 0d6f20d to 9fd3d10 Compare January 20, 2025 23:50
@aorumbayev aorumbayev force-pushed the prerelease/typed_client_methods branch from a22e479 to dd56bcb Compare January 22, 2025 10:39
Copy link

Coverage

Coverage Report
FileStmtsMissCoverMissing
src/algokit_utils
   _debugging.py1501093%21, 42, 81, 87, 96, 136, 164, 172–174
   application_client.py330%1–11
   config.py891880%26–28, 41, 53, 84–85, 100, 105, 110, 118–123, 156, 158, 160
   deploy.py330%1–10
   logic_error.py330%1–10
src/algokit_utils/_legacy_v2
   _ensure_funded.py71199%100
   _transfer.py70396%14, 77–78
   account.py931386%15–18, 70–74, 109, 126, 156, 159, 208
   application_client.py5327786%60–61, 178, 183, 212, 324, 329–330, 332, 334, 799, 814, 832–835, 925, 965, 977, 990, 1032, 1092–1098, 1102–1107, 1109, 1145, 1152, 1265, 1299, 1313, 1351–1353, 1355, 1365–1422, 1433–1438, 1458–1461
   asset.py82594%10, 28–31
   common.py13192%13
   deploy.py4332295%32–35, 170, 174–175, 193, 249, 339–340, 361, 395, 406–414, 429, 437, 630–631, 655
   network_clients.py73593%77–78, 101–102, 135
src/algokit_utils/accounts
   account_manager.py2114181%169–170, 202–208, 225, 242–247, 257–262, 302–304, 339–340, 379, 399–403, 416, 479, 658, 772, 855, 860, 878, 881–882, 905
   kmd_account_manager.py71889%57–61, 110, 183, 190
src/algokit_utils/applications
   abi.py1287045%56, 78, 84, 86, 88, 92–93, 100–119, 128, 131–137, 145–158, 164–176, 184–195
   app_client.py73821072%65–73, 136, 144, 385–388, 391, 394, 397, 400, 412–415, 418, 421, 424, 427, 439, 448, 457, 462–524, 537–595, 628–630, 639–642, 645–648, 651–654, 657–660, 663–666, 669–672, 685, 747–748, 776, 781, 786, 791, 796, 801, 816, 819, 822, 825, 828, 831, 860–866, 872, 879, 886, 893, 902, 919, 955, 1037, 1057, 1086–1087, 1106, 1108, 1114, 1144–1152, 1174–1177, 1180–1183, 1204, 1240, 1253, 1324–1331, 1356, 1368, 1370, 1373, 1377, 1478, 1496–1497, 1535, 1546–1548, 1552–1575, 1586, 1595–1606, 1614–1619
   app_deployer.py2334083%96, 230, 237, 247–252, 255–259, 297–311, 326–327, 512–525, 535, 540, 546, 552–554, 561, 575, 586–627
   app_factory.py2752790%379, 389, 392, 562, 570, 582, 727, 741–746, 752–753, 772, 797, 808–809, 845, 853–867
   app_manager.py2181693%191, 221–222, 239–244, 265, 276–277, 307, 320–323, 338, 347
src/algokit_utils/applications/app_spec
   arc32.py95892%195–204
   arc56.py4703692%66–68, 140, 223, 234–235, 283, 296–298, 330, 339, 341, 383, 545, 555, 559, 697, 699, 732–743, 756, 758–759, 775
src/algokit_utils/assets
   asset_manager.py1271291%223–224, 233, 239–254, 264
src/algokit_utils/beta
   __init__.py21210%1–67
src/algokit_utils/clients
   algorand_client.py941386%62–63, 72–73, 96–98, 107–108, 202, 222, 235, 251
   client_manager.py1664970%56–63, 69, 93–95, 125, 130–133, 147, 174, 198–201, 223, 247, 259, 273, 290–293, 314–317, 350–353, 374–377, 398–423, 449, 461, 470
   dispenser_api_client.py831286%126–127, 131–134, 169–171, 190–192
src/algokit_utils/errors
   logic_error.py561279%14, 38, 105–121
src/algokit_utils/models
   account.py63690%81, 86, 107–114
   amount.py1155651%34, 58, 66, 120, 125–128, 132, 135–141, 148, 151–155, 158–162, 165–169, 172–176, 179–183, 186–192, 195–198, 201–207
   application.py42198%8
   state.py36586%51, 55–58
   transaction.py55493%56, 66, 86, 91
src/algokit_utils/protocols
   client.py381074%8–18
src/algokit_utils/transactions
   transaction_composer.py5985491%32–41, 640, 682, 842–843, 869–870, 906, 942–946, 1080, 1085, 1114–1152, 1272, 1275, 1401, 1403–1404, 1453–1454
   transaction_creator.py75791%120, 125, 130, 135, 140, 145, 160
   transaction_sender.py1481093%83, 208, 249–250, 339–344, 349–350, 374
   utils.py2026866%31, 45, 52, 76, 78, 80, 97, 103, 131–194, 223, 241–243, 249–264, 271–278, 281–288, 299, 367, 370, 375, 379–390
TOTAL617996084% 

Tests Skipped Failures Errors Time
355 0 💤 0 ❌ 0 🔥 2m 56s ⏱️

@aorumbayev aorumbayev marked this pull request as ready for review January 22, 2025 11:54
@aorumbayev aorumbayev merged commit 8024d37 into prerelease/ts-feature-parity Jan 22, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants