Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement onnx export for inception3/4, resnext, mobilenetv2 #346

Merged
merged 12 commits into from
Jul 18, 2024

Conversation

lostkevin
Copy link
Contributor

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Please describe the motivation of this PR and the goal you want to achieve through this PR.

Modification

Please briefly describe what modification is made in this PR.

Backward-Compatibility-Breaking (Optional)

Does the modification introduce changes that break the backward-compatibility? If so, please describe how it breaks the compatibility in this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Pull-Request Todo List

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. The documentation has been modified accordingly, like docstring or example tutorials.

tools/export.py Outdated
@@ -80,7 +80,7 @@ def main():
cfg = mmcv_config_fromfile(args.config)

if args.user_config_params is not None:
assert args.model_type is not None, 'model_type must be setted'
# assert args.model_type is not None, 'model_type must be setted'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这一行为什么注释掉

Copy link
Contributor Author

@lostkevin lostkevin Jul 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

搞错逻辑了,已修复

)
])

class_list = [
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

inception这几个配置文件可以提取一个base 配置吗,看起来重复度很高

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@Cathy0908 Cathy0908 merged commit 3189798 into alibaba:master Jul 18, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants