Integrate HW implementations from Intel & Arm for both CRC32C & CRC64-ECMA #694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lihuiba
changed the title
lihuiba
force-pushed
the
crc+isal
branch
6 times, most recently
from
cf5720c to
7000c87
Compare
beef9999
requested changes
Jan 7, 2025
.github/workflows/ci.linux.arm.yml
Outdated
| @@ -46,7 +46,7 @@ jobs: | |||
| debug-build-from-source: | |||
| runs-on: ubuntu-latest | |||
| container: | |||
| image: almalinux:8 | |||
| image: ghcr.io/alibaba/photon-ut-base:latest | |||
There was a problem hiding this comment.
这个地方不动吧。build-from-source 测试的就是从一个裸镜像没有安装任何依赖来构建photon，会走网络下载源码包
beef9999
reviewed
Jan 7, 2025
| @@ -22,7 +22,7 @@ jobs: | |||
| - name: Install Dependencies | |||
| shell: bash | |||
| run: | | |||
| brew install cmake openssl gflags googletest gsasl | |||
| brew install cmake openssl gflags googletest gsasl nasm | |||
There was a problem hiding this comment.
需要改官网doc吗？这个crc是否是默认开启的
There was a problem hiding this comment.
晚点再改，@Coldwings 会把这个做成可选的。
lihuiba
force-pushed
the
crc+isal
branch
4 times, most recently
from
80bb6bf to
3e0b705
Compare
beef9999
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Have modified the source code slightly to minimize the number of files included.