Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update metrics & enable lds cache #1650

Merged
merged 5 commits into from
Jan 8, 2025

Conversation

johnlanni
Copy link
Collaborator

Ⅰ. Describe what this PR did

  1. The previous liteMetrics was already quite comprehensive, so it is used as the default metrics
  2. When liteMetrics=true, the behavior is modified to not perform any tag extraction in the data plane
  3. LDS cache is enabled by default

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@johnlanni johnlanni requested a review from SpecialYang as a code owner January 7, 2025 13:23
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.62%. Comparing base (ef31e09) to head (82b51d9).
Report is 254 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1650      +/-   ##
==========================================
+ Coverage   35.91%   43.62%   +7.71%     
==========================================
  Files          69       76       +7     
  Lines       11576    12356     +780     
==========================================
+ Hits         4157     5390    +1233     
+ Misses       7104     6628     -476     
- Partials      315      338      +23     

see 70 files with indirect coverage changes

@johnlanni johnlanni merged commit e97448b into alibaba:main Jan 8, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants