支持 subpath 路由 #2026
Open
支持 subpath 路由 #2026
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henryzhx8
requested changes
Jan 8, 2025
messixukejia
requested changes
Jan 9, 2025
| @@ -294,16 +294,57 @@ bool FlusherSLS::Init(const Json::Value& config, Json::Value& optionalGoPipeline | |||
| mContext->GetRegion()); | |||
| } | |||
|
|
|||
| // TelemetryType | |||
| string telemetryType; | |||
| if (!GetOptionalStringParam(config, "TelemetryType", telemetryType, errorMsg)) { | |||
There was a problem hiding this comment.
298-347这段逻辑 处理顺序是 log、metric、arms。
| logData, | ||
| bufferMeta.rawsize(), | ||
| bufferMeta.has_shardhashkey() ? bufferMeta.shardhashkey() : "", | ||
| bufferMeta.subpath()); |
| const std::string& subPath) const { | ||
|
|
||
| optional<uint64_t> seqId; | ||
| if (item->mExactlyOnceCheckpoint) { |
messixukejia
reviewed
Jan 9, 2025
| @@ -80,6 +80,8 @@ static sls_logs::EndpointMode GetEndpointMode(EndpointMode mode) { | |||
| static const string kAKErrorMsg = "can not get valid access key"; | |||
| #endif | |||
|
|
|||
| static const string kNoSubpathErrorMsg = "subpath not set"; | |||
There was a problem hiding this comment.
diskbuffer需要有E2E覆盖，可以找笃敏交流下
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.