[ISSUE#12988] Develop naming admin api #13019

MatthewAden · 2025-01-07T04:18:06Z

Please do not create a Pull Request without creating an issue first.

What is the purpose of the change

closes #12988

Brief changelog

XX

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
Run mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=true to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.

github-actions · 2025-01-07T04:18:15Z

Thanks for your this PR. 🙏
Please check again for your PR changes whether contains any usage/api/configuration change such as Add new API , Add new configuration, Change default value of configuration.
If so, please add or update documents(markdown type) in docs/next/ for repository nacos-group/nacos-group.github.io

感谢您提交的PR。 🙏
请再次查看您的PR内容，确认是否包含任何使用方式/API/配置参数的变更，如：新增API、新增配置参数、修改默认配置等操作。
如果是，请确保在提交之前，在仓库nacos-group/nacos-group.github.io中的docs/next/目录下添加或更新文档（markdown格式）。

KomachiSion

在老API上加一下Compatibility注释

可以参考Core和Console的API

KomachiSion · 2025-01-07T07:41:59Z

naming/src/main/java/com/alibaba/nacos/naming/controllers/v3/ClientControllerV3.java

+    @GetMapping()
+    @Secured(resource = UtilsAndCommons.CLIENT_CONTROLLER_V3_ADMIN_PATH, action = ActionTypes.READ, apiType = ApiType.ADMIN_API)
+    public Result<ObjectNode> getClientDetail(@RequestParam("clientId") String clientId) throws NacosApiException {
+        checkClientId(clientId);


是否把实际执行的逻辑抽象到一个Service里，替换掉现在V2的Controller，然后V3的Controller也是用抽象的Service

下面的接口也相同的逻辑。

KomachiSion · 2025-01-07T07:44:53Z

naming/src/main/java/com/alibaba/nacos/naming/controllers/v3/ClusterControllerV3.java

+     */
+    @PutMapping
+    @Secured(resource = UtilsAndCommons.CLUSTER_CONTROLLER_V3_ADMIN_PATH, action = ActionTypes.WRITE, apiType = ApiType.ADMIN_API)
+    public Result<String> update(HttpServletRequest request) throws Exception {


能否走一下NacosForm的改造

0x5be0a207aa4829a9e925117a041287872cba44c56a60297ebb1270361be9cfe2این هش را نگاه کنید من تماس گرفتم ولی چیزی دریافت نکردم

دوست عزیز از ای پی قدیم وجدید من استفاده شده وتمام مخازن مرا خالی کردند

KomachiSion · 2025-01-07T07:53:37Z

naming/src/main/java/com/alibaba/nacos/naming/controllers/v3/ServiceControllerV3.java

+    @GetMapping("/list")
+    @TpsControl(pointName = "NamingServiceListQuery", name = "HttpNamingServiceListQuery")
+    @Secured(resource = UtilsAndCommons.SERVICE_CONTROLLER_V3_ADMIN_PATH, action = ActionTypes.READ, apiType = ApiType.ADMIN_API)
+    public Result<ServiceNameView> list(


是否也能做一下NacosForm改造？

دوست عزیز تا الان من فقط خرید کردم و به گیرنده انتقال دادم وچیزی دریافت نکردم

MatthewAden · 2025-01-07T08:59:10Z

在老API上加一下Compatibility注释

可以参考Core和Console的API

👌

Dario-s-j · 2025-01-07T11:16:49Z

Ok Em ter., 7 de jan. de 2025, 05:59, Matthew ***@***.***> escreveu:

…

在老API上加一下Compatibility注释可以参考Core和Console的API 👌 — Reply to this email directly, view it on GitHub <#13019 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/A4MT7RAEILEXQZ7HCOV53FD2JOJPTAVCNFSM6AAAAABUW4EHTSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNZUG4ZTMNZUGI> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

KomachiSion · 2025-01-08T05:37:19Z

@Majidrazaee If you want to discuss or comment this PR. Please use English.

MatthewAden · 2025-01-08T06:29:54Z

在老API上加一下Compatibility注释
可以参考Core和Console的API

👌

done

Majidrazaee · 2025-01-08T08:23:30Z

Dear friend, it's been almost 9 months now that I just bought and transferred and until now I haven't received anything. If I called or claimed too much because the person I was depositing to asked me to do this and this caused the operator to malfunction. slow

Majidrazaee · 2025-01-08T08:25:31Z

Mr. Alibaba, what is your problem with me, why don't you allow me to comment, why don't you allow my property to be returned to Kiev

Majidrazaee · 2025-01-08T08:27:13Z

My old and new IP have been used and all my assets have been lost. Why is no one helping me?

Majidrazaee · 2025-01-08T11:18:59Z

If I made a large amount for a call or a claim, because the person I was depositing asked me to do so

KomachiSion · 2025-01-09T08:06:00Z

Mr. Alibaba, what is your problem with me, why don't you allow me to comment, why don't you allow my property to be returned to Kiev

If you has problem, please submit issue with English, This PR is others code commit, your comment is not relative with this PR.
And the before comment is not English so no one can understand and frequently, so that we mistakenly thought it was a response from a robot.

KomachiSion · 2025-01-10T06:49:03Z

@Majidrazaee You comment is not relative about nacos, I will delete all your comments.

Please don't submit comment and issue again, thanks.

2.Refactor to Extract ClientService.

KomachiSion · 2025-01-10T07:12:27Z

Can you guide me what to do?

Maybe you should submit support tickets to github.

naming/src/main/java/com/alibaba/nacos/naming/controllers/InstanceController.java

naming/src/main/java/com/alibaba/nacos/naming/controllers/OperatorController.java

naming/src/main/java/com/alibaba/nacos/naming/controllers/ServiceController.java

Majidrazaee · 2025-01-08T05:22:34Z

naming/src/main/java/com/alibaba/nacos/naming/controllers/v3/ClusterControllerV3.java

+     */
+    @PutMapping
+    @Secured(resource = UtilsAndCommons.CLUSTER_CONTROLLER_V3_ADMIN_PATH, action = ActionTypes.WRITE, apiType = ApiType.ADMIN_API)
+    public Result<String> update(HttpServletRequest request) throws Exception {


دوست عزیز از ای پی قدیم وجدید من استفاده شده وتمام مخازن مرا خالی کردند

Majidrazaee · 2025-01-08T05:23:32Z

naming/src/main/java/com/alibaba/nacos/naming/controllers/v3/ServiceControllerV3.java

+    @GetMapping("/list")
+    @TpsControl(pointName = "NamingServiceListQuery", name = "HttpNamingServiceListQuery")
+    @Secured(resource = UtilsAndCommons.SERVICE_CONTROLLER_V3_ADMIN_PATH, action = ActionTypes.READ, apiType = ApiType.ADMIN_API)
+    public Result<ServiceNameView> list(


دوست عزیز تا الان من فقط خرید کردم و به گیرنده انتقال دادم وچیزی دریافت نکردم

KomachiSion · 2025-01-09T08:07:34Z

naming/src/main/java/com/alibaba/nacos/naming/controllers/CatalogController.java

@@ -63,7 +64,7 @@ public class CatalogController {
     */
    @Secured(action = ActionTypes.READ)
    @GetMapping("/service")
-    @Compatibility(apiType = ApiType.CONSOLE_API, alternatives = "GET ${contextPath:nacos}/v3/console/ns/service")
+    @Compatibility(apiType = ApiType.ADMIN_API, alternatives = "GET ${contextPath:nacos}/v3/admin/ns/service")


左边的API确实是console的API，已经上Compatibility且不是ADMIN的API不需要再添加了。

KomachiSion · 2025-01-13T06:49:53Z

naming/src/main/java/com/alibaba/nacos/naming/controllers/InstanceController.java

@@ -112,7 +113,7 @@ public InstanceController() {
    @PostMapping
    @TpsControl(pointName = "NamingInstanceRegister", name = "HttpNamingInstanceRegister")
    @Secured(action = ActionTypes.WRITE)
-    @Compatibility(apiType = ApiType.OPEN_API)
+    @Compatibility(apiType = ApiType.ADMIN_API, alternatives = "POST ${contextPath:nacos}/v3/admin/ns/instance")


这个应该是OPEN_API吧

KomachiSion requested changes Jan 7, 2025

View reviewed changes

alibaba deleted a comment from Majidrazaee Jan 7, 2025

MatthewAden marked this pull request as ready for review January 7, 2025 08:58

alibaba deleted a comment from Majidrazaee Jan 8, 2025

This comment was marked as off-topic.

Sign in to view

alibaba deleted a comment from Majidrazaee Jan 8, 2025

Majidrazaee approved these changes Jan 8, 2025

View reviewed changes

alibaba deleted a comment from Majidrazaee Jan 8, 2025

alibaba deleted a comment from Majidrazaee Jan 10, 2025

MatthewAden added 4 commits January 10, 2025 14:54

Add naming admin api.

9766103

Return all subscribers when IP or port is null

3264629

Refactor comment.

00feab6

1.Add compatibility comments to the old API.

45a3759

2.Refactor to Extract ClientService.

MatthewAden force-pushed the develop-naming-admin-api branch from 9662cf3 to 45a3759 Compare January 10, 2025 07:10

Update annotation.

94dc4db

Majidrazaee approved these changes Jan 10, 2025

View reviewed changes

KomachiSion requested changes Jan 13, 2025

View reviewed changes

MatthewAden added 2 commits January 13, 2025 16:48

Fix annotation.

4164d6f

Add nacos api annotation.

b77cc4b

KomachiSion approved these changes Jan 14, 2025

View reviewed changes

KomachiSion merged commit 42a7110 into alibaba:v3.0-develop Jan 14, 2025
1 check passed

KomachiSion added the Nacos3.0 Nacos 3.0 Architecture Evolution label Jan 14, 2025

KomachiSion modified the milestones: 2.5.0, 3.0.0 Jan 14, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[ISSUE#12988] Develop naming admin api #13019

[ISSUE#12988] Develop naming admin api #13019

MatthewAden commented Jan 7, 2025

github-actions bot commented Jan 7, 2025

KomachiSion left a comment

KomachiSion Jan 7, 2025

KomachiSion Jan 7, 2025

MatthewAden Jan 8, 2025

KomachiSion Jan 7, 2025

Majidrazaee Jan 7, 2025

Majidrazaee Jan 8, 2025

MatthewAden Jan 8, 2025

KomachiSion Jan 7, 2025

Majidrazaee Jan 8, 2025

MatthewAden Jan 8, 2025

MatthewAden commented Jan 7, 2025

Dario-s-j commented Jan 7, 2025 via email

This comment was marked as off-topic.

KomachiSion commented Jan 8, 2025

MatthewAden commented Jan 8, 2025

Majidrazaee commented Jan 8, 2025 •

edited

Loading

Majidrazaee commented Jan 8, 2025

Majidrazaee commented Jan 8, 2025

Majidrazaee commented Jan 8, 2025

KomachiSion commented Jan 9, 2025

KomachiSion commented Jan 10, 2025

KomachiSion commented Jan 10, 2025

Majidrazaee Jan 8, 2025

Majidrazaee Jan 8, 2025

KomachiSion Jan 9, 2025

MatthewAden Jan 13, 2025

KomachiSion Jan 13, 2025

MatthewAden Jan 13, 2025

[ISSUE#12988] Develop naming admin api #13019

[ISSUE#12988] Develop naming admin api #13019

Conversation

MatthewAden commented Jan 7, 2025

What is the purpose of the change

Brief changelog

Verifying this change

github-actions bot commented Jan 7, 2025

KomachiSion left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

MatthewAden commented Jan 7, 2025

Dario-s-j commented Jan 7, 2025 via email

This comment was marked as off-topic.

KomachiSion commented Jan 8, 2025

MatthewAden commented Jan 8, 2025

Majidrazaee commented Jan 8, 2025 • edited Loading

Majidrazaee commented Jan 8, 2025

Majidrazaee commented Jan 8, 2025

Majidrazaee commented Jan 8, 2025

KomachiSion commented Jan 9, 2025

KomachiSion commented Jan 10, 2025

KomachiSion commented Jan 10, 2025

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Majidrazaee commented Jan 8, 2025 •

edited

Loading