Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support json readpath function #362

Merged
merged 1 commit into from
Jan 16, 2025
Merged

Conversation

PanPanZou
Copy link
Collaborator

No description provided.

@CLAassistant
Copy link

CLAassistant commented Jan 16, 2025

CLA assistant check
All committers have signed the CLA.

@codecov-commenter
Copy link

codecov-commenter commented Jan 16, 2025

Codecov Report

Attention: Patch coverage is 97.07317% with 6 lines in your changes missing coverage. Please review.

Project coverage is 82.69%. Comparing base (3cece40) to head (cde1e54).

Files with missing lines Patch % Lines
csharp/core/Common.cs 92.72% 2 Missing and 2 partials ⚠️
csharp/tests/CommonTest.cs 98.38% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             master     #362       +/-   ##
=============================================
+ Coverage     71.62%   82.69%   +11.06%     
- Complexity      236      247       +11     
=============================================
  Files            14       23        +9     
  Lines          1431     2433     +1002     
  Branches         46      118       +72     
=============================================
+ Hits           1025     2012      +987     
- Misses          393      397        +4     
- Partials         13       24       +11     
Flag Coverage Δ
csharp 97.75% <96.64%> (?)
golang 91.70% <ø> (ø)
java 69.62% <100.00%> (+4.44%) ⬆️
php 0.00% <ø> (ø)
python 98.63% <ø> (ø)
ts 96.11% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

yndu13
yndu13 previously approved these changes Jan 16, 2025
@PanPanZou PanPanZou force-pushed the support-json-readpath branch 3 times, most recently from 1a84ee3 to 4ac87c6 Compare January 16, 2025 09:03
@PanPanZou PanPanZou force-pushed the support-json-readpath branch from 4ac87c6 to cde1e54 Compare January 16, 2025 09:25
@yndu13 yndu13 merged commit 5f4bdeb into master Jan 16, 2025
36 of 43 checks passed
@yndu13 yndu13 deleted the support-json-readpath branch January 16, 2025 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants