Pull Request: Addition of "general-preference" Branch for General Preference Model (GPM) #201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add torch_dtype to model GPM
natolambert
requested changes
Oct 23, 2024
There was a problem hiding this comment.
Hey @kirigayahitsugi -- sorry for the delay. In general this is great. I'm wondering how we can minimize modifications to the script. Right now, some of the moderations effect all the models (truncation) instead of just the new types of models. I am wondering if we can do this in a bit cleaner of a way.
Same goes for the custom classifier section where there is a lot of additions.
Lastly, seems like we want to remove the extra bash script you accidentally checked in?
natolambert
reviewed
Oct 23, 2024
scripts/run_rm.py
Outdated
| @@ -89,6 +89,13 @@ def get_args(): | |||
| choices=["eager", "sdpa", "flash_attention_2"], | |||
| help="Attention implementation to use (default: None)", | |||
| ) | |||
| #### custom arguments added for general-preference/GPM-Llama-3.1-8B and general-preference/GPM-Gemma-2B | |||
There was a problem hiding this comment.
I'd like to not add any args if possible, if just for one model. Given we already have a config structure.
scripts/run_rm.py
Outdated
Comment on lines
137
to
138
| # #### added for general-preference/GPM-Llama-3.1-8B and general-preference/GPM-Gemma-2B for debugging | ||
| # config = REWARD_MODEL_CONFIG["general-preference/GPM-Gemma-2B"] |
scripts/run_rm.py
Outdated
Comment on lines
188
to
190
| #### added for general-preference/GPM-Llama-3.1-8B and general-preference/GPM-Gemma-2B | ||
| tokenizer.truncation_side = "right" | ||
| tokenizer.padding_side = "left" |
…d-bench into general-preference
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dear RewardBench Team,
I am submitting a Pull Request to introduce a new branch named "general-preference" to support the General Preference Model (GPM). The following modifications have been implemented:
Thank you for considering this addition!
Best regards,
Grace Zhang