-
-
Notifications
You must be signed in to change notification settings - Fork 432
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow sending panels to SourceTV client via settings #2239
Conversation
This seems like too much faff around it, based on the discussion in the previous PR just removing the |
I think it would be nice to keep the default behavior? |
It's just that the old PR was never accepted and I thought it wasn't worth changing the default behavior, of course I can remove the extra code if you say so. |
Done, I made one check for SourceTV, I don't know if it is needed for other bots, let someone else make a PR if it is needed for ReplayClient. There is no way to check for ReplayClient. |
Presumably nothing breaks if sent to other fake clients? We should err on trusting the plugin that it is doing what it wants. |
Let the plugin decide who to send the menu to
Done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, @psychonic ?
Code tested in game Left4Dead2, menu successfully sent to SourceTV client.
Close #1563
Related PR #1775