Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow sending panels to SourceTV client via settings #2239

Merged
merged 4 commits into from
Dec 30, 2024

Conversation

A1mDev
Copy link
Contributor

@A1mDev A1mDev commented Dec 30, 2024

Code tested in game Left4Dead2, menu successfully sent to SourceTV client.

Close #1563
Related PR #1775

@asherkin
Copy link
Member

This seems like too much faff around it, based on the discussion in the previous PR just removing the pPlayer->IsFakeClient() check seems good enough? The client index is passed in, I don't think we need an additional param of "yes, I really meant to pass that client index in".

@A1mDev
Copy link
Contributor Author

A1mDev commented Dec 30, 2024

I think it would be nice to keep the default behavior?

@A1mDev
Copy link
Contributor Author

A1mDev commented Dec 30, 2024

It's just that the old PR was never accepted and I thought it wasn't worth changing the default behavior, of course I can remove the extra code if you say so.

@A1mDev
Copy link
Contributor Author

A1mDev commented Dec 30, 2024

Done, I made one check for SourceTV, I don't know if it is needed for other bots, let someone else make a PR if it is needed for ReplayClient. There is no way to check for ReplayClient.

@asherkin
Copy link
Member

Presumably nothing breaks if sent to other fake clients? We should err on trusting the plugin that it is doing what it wants.

Let the plugin decide who to send the menu to
@A1mDev
Copy link
Contributor Author

A1mDev commented Dec 30, 2024

Done

Copy link
Member

@asherkin asherkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, @psychonic ?

@psychonic psychonic merged commit a44cfe1 into alliedmodders:master Dec 30, 2024
3 of 4 checks passed
@A1mDev A1mDev deleted the sourcetv_menu branch December 30, 2024 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sourcemod menus do not show for Source TV (L4D2)
3 participants