-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update frontend performance #899
Conversation
Makes some minor style and wording changes to the content in response to comments during a review at the frontend community meeting.
Adds a section on code splitting to provide a bit more nuance to the 'minimise HTTP requests' guideline.
Adds a recommendation to enable HTTP/2 or HTTP/3, since this is now well supported.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added a comment but it seems like it also could just be my opinion so approving as everything else makes total sense and looks good to go 👍🏻
Thanks for doing the hard work of meeting and coming up with changes!
Clarifies the wording on this item to make it clearer that we're talking about minimising the number of requests, to avoid round trips to the server.
Sorry @tombye, looks like your review got dismissed when I updated the bit about server round-trips - would you mind re-reviewing if you've got time? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking great, thanks again for doing the work 👍🏻
Makes some updates to the FE performance page, as suggested by the frontend community. Main changes: