Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to the Secret Auditing page #954

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

minglis
Copy link

@minglis minglis commented Oct 31, 2024

As per discussion in GDS Lead Tech meeting - action was to review the guidance on GitHub secret scanning with security colleagues.

Proposal is to upgrade the use of GitHub secret scanning to a must from should.

This change also recommends that teams must review alerts on a regular basis, timing of this suggested to be aligned to existing team processes.

Teams also must record outcomes, even for false positives.

…hnologists meeting. GitHub secret scanning upgraded to a must. Team must also review alerts and record outcomes.
Copy link
Member

@huwd huwd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with this DI are making similar moves right now.

Copy link
Member

@timblair timblair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We discussed this in the GDS Way meeting, and are 👍 with it. Please can you update the review date before you merge this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants