Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rationalise ratelimit exemption rules. #1810

Merged
merged 5 commits into from
Dec 14, 2023
Merged

Rationalise ratelimit exemption rules. #1810

merged 5 commits into from
Dec 14, 2023

Conversation

sengi
Copy link
Contributor

@sengi sengi commented Dec 14, 2023 •
edited
Loading

Make it clearer as to what the rule does. See:

@sengi
Rationalise ratelimit exemption rules.
645d041 
Make it clearer as to what the rule does.
robinjam
robinjam approved these changes Dec 14, 2023
View reviewed changes
Copy link
Contributor

@robinjam robinjam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

KludgeKML
KludgeKML approved these changes Dec 14, 2023
View reviewed changes
Copy link
Contributor

@KludgeKML KludgeKML left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense!

sihugh
sihugh approved these changes Dec 14, 2023
View reviewed changes
Copy link
Contributor

@sihugh sihugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've found the rule precedence numbering getting reset by AWS at times, possibly by the odd clickopsing thing. It has no effect other than making the TF diffs annoying.

sengi added 4 commits December 14, 2023 15:12
@sengi
Fix statement numbering to make edits less painful.
6fd4aa8
@sengi
Heed ratelimit exemptions in backend WAF ruleset.
d0e0127
@sengi
Remove defunct WAF association objects for CKAN.
0040995 
These were referring to LBs that no longer exist, and their replacements
are configured via aws-lb-controller and not Terraform.
@sengi
Regenerate docs.
bb05970
@sengi sengi force-pushed the sengi/fix-ratelimits branch from f4ad068 to bb05970 Compare December 14, 2023 15:12
@sengi
Copy link
Contributor Author

sengi commented Dec 14, 2023

/me regenerates the docs again 🙃

@sengi
Copy link
Contributor Author

sengi commented Dec 14, 2023

We've found the rule precedence numbering getting reset by AWS at times, possibly by the odd clickopsing thing. It has no effect other than making the TF diffs annoying.

Ohh, I see. Which way is better do you reckon? (Should people be clickopsing these?)

@sengi sengi merged commit cfe31b0 into main Dec 14, 2023
4 checks passed
@sengi sengi deleted the sengi/fix-ratelimits branch December 14, 2023 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KludgeKML KludgeKML KludgeKML approved these changes

@sihugh sihugh sihugh approved these changes

@robinjam robinjam robinjam approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sengi @robinjam @sihugh @KludgeKML