Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up publishing-amazonmq ready for moving. #1826

Merged
merged 2 commits into from
Apr 19, 2024
Merged

Clean up publishing-amazonmq ready for moving. #1826

merged 2 commits into from
Apr 19, 2024

Conversation

sengi
Copy link
Contributor

@sengi sengi commented Apr 19, 2024

  • Avoid relying on a DNS query that only works when running Terraform from inside the VPC.
  • Remove references to the deleted govuk_management_access security group.
  • Update TF and provider versions.
  • Remove disused variables.
  • Fix lint errors.
  • Strip redundant comments.
  • Fix AWS tagging.

Tested: applied in the staging and integration accounts.

alphagov/govuk-infrastructure#1267

@sengi sengi requested a review from samsimpson1 April 19, 2024 14:16
@sengi sengi marked this pull request as ready for review April 19, 2024 14:16

Verified

This commit was signed with the committer’s verified signature.
weblate Weblate (bot)
- Avoid relying on a DNS query that only works when running Terraform
  from inside the VPC.
- Remove references to the deleted `govuk_management_access` security
  group.
- Update TF and provider versions.
- Remove disused variables.
- Fix lint errors.
- Strip redundant comments.
- Fix AWS tagging.

Tested: applied in staging.
Terraform isn't sophisticated enough to determine that it needs to fetch
some of the data resources to determine the input value to for_each. So
we go back to using the ugly `count()` workaround as before.
@sengi sengi merged commit 217d79a into main Apr 19, 2024
2 checks passed
@sengi sengi deleted the sengi/mq branch April 19, 2024 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants