[DO NOT MERGE] - Refactor asset-manager clamav labels #2926
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Description: - Currently `clamav-pvc` will match onto any `PersistentVolume` with `app.kubernetes.io/instance: asset-manager` as this is contained in `asset-manager.selectorLabels`. However if another `PersistentVolume` were to be deployed with `asset-manager.selectorLabels` there is a chance it will match onto that rather than `clamav-pv` which is the wrong result - Ensure it only matches on labels that end in `-clamav-db` preventing this mixup - As part of #1883
theseanything
approved these changes
Jan 23, 2025
nimalank7
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
clamav-pvcwill match onto anyPersistentVolumewithapp.kubernetes.io/instance: asset-manageras this is contained inasset-manager.selectorLabels. However if anotherPersistentVolumewere to be deployed withasset-manager.selectorLabelsthere is a chance it will match onto that rather thanclamav-pvwhich is the wrong result-clamav-dbpreventing this mixup