Tidy up IAM policies for publishing components' S3 permissions. #1153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
sengi
commented
Feb 28, 2024
sengi
commented
- Rename some resources to better reflect their use.
- Get rid of an IAM policy that wasn't buying us anything by being separate.
- Tidy up the HCL syntax to reduce the excessive verbosity a bit (because it's even harder to understand an AWS IAM policy when it doesn't fit on a screen 😅)
No functional change. Just minimise the excessive HCL verbosity to make the policies slightly easier to read.
Several "publishing" (i.e. CMS) components write (non-sensitive) reports to S3 buckets. Some of these happen to be in CSV format. Currently, the permissions for writing to these report buckets are split arbitrarily (for purely historical reasons) between a handful of different IAM policies all attached to the node role. It makes sense to consolidate these for now, at least so that it's easier to see where to add/change stuff (for example recently in dea2db5).
There's no benefit in having a separate, almost-identical IAM policy for Publishing API to write event logs to S3 when both policies are attached to the node role anyway. If we were to someday split up the roles, assign them to serviceaccounts and use pod identity (almost certainly overkill in this case) then it would make sense to have separate policies. Until then, it's just additional toil and potential for confusion (which itself is not good for security).
sengi
force-pushed
the
sengi/iam-cleanup
branch
from
7c7f4c8 to
0244cb3
Compare
theseanything
approved these changes
Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.