Modified test v5 with sprockets #362
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a major breaking change in moving to v5 of the design system one of the key consequences was moving files onto a new /dist path. in line with guidance here we're updating it, see their changelog for more details: https://github.com/alphagov/govuk-frontend/blob/main/CHANGELOG.md#500-breaking-release
This mixin has been removed and we're no longer targeting any IE prior to 11, so removing this out, see: https://github.com/alphagov/govuk-frontend/blob/main/CHANGELOG.md#500-breaking-release
Works for serve, but not yet for build DS accordion JS http://localhost:4567/test-accordion.html
This seems to allow us to ensure a file called govuk-frontent.js is present in the build folder. Wondering if this allows us to solve the issue and bring both into the <head> scripts?
but without minification as the minifier doesn support e6 In your downstream project - create a file called "govuk_frontend.js" in assets/javascript folder - add //= require govuk_frontend_all - serve or build
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What’s changed
Identifying a user need