fix(style): remove whitespace before comma #2378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
george-gca
approved these changes
Apr 29, 2024
|
Thanks for this fix. I believe we might have quite a few of these hidden under particular cases, but like this one we'll only find them when they happen. |
BoAi01
pushed a commit
to BoAi01/boai01.github.io
that referenced
this pull request
May 7, 2024
This PR fixes a very niche bug. If there is a co-author that is not *me* (=`<em>` tagged) and does not have a `coauthor_url` (=`<a>` tagged), there will be a leading whitespace before the separating comma. If the author list is split into multiple lines (due to long author lists or a small view), the whitespace can lead to a line beginning with a comma. As I said, very niche, but interestingly, the other cases already did the same whitespace handling. Just the case not-me/no-url was mising. Currently, we do not have this case on vanilla al-folio, but you can see it for example on [my website](https://christianmainka.de/publications/) if the view is small (e.g., 430px). Related to alshedivat#1502.
siril-teja
pushed a commit
to siril-teja/siril-teja.github.io-old
that referenced
this pull request
Jun 19, 2024
This PR fixes a very niche bug. If there is a co-author that is not *me* (=`<em>` tagged) and does not have a `coauthor_url` (=`<a>` tagged), there will be a leading whitespace before the separating comma. If the author list is split into multiple lines (due to long author lists or a small view), the whitespace can lead to a line beginning with a comma. As I said, very niche, but interestingly, the other cases already did the same whitespace handling. Just the case not-me/no-url was mising. Currently, we do not have this case on vanilla al-folio, but you can see it for example on [my website](https://christianmainka.de/publications/) if the view is small (e.g., 430px). Related to alshedivat#1502.
|
@george-gca what issues were you seeing with this when you initially tried? I just did a find/replace for 174 instances across the below files and so far I haven't noticed any issues. But maybe I'm missing something obvious.
Example diff
|
|
It is quite the opposite. I was adding the |
Ah okay sorry I just realized I meant to add this comment over in #1502 That being said, I think I misunderstood the original find/replace and have it backwards. Thanks for clarifying. Will mess around with it |
karapostK
pushed a commit
to karapostK/karapostK.github.io
that referenced
this pull request
Jul 4, 2024
This PR fixes a very niche bug. If there is a co-author that is not *me* (=`<em>` tagged) and does not have a `coauthor_url` (=`<a>` tagged), there will be a leading whitespace before the separating comma. If the author list is split into multiple lines (due to long author lists or a small view), the whitespace can lead to a line beginning with a comma. As I said, very niche, but interestingly, the other cases already did the same whitespace handling. Just the case not-me/no-url was mising. Currently, we do not have this case on vanilla al-folio, but you can see it for example on [my website](https://christianmainka.de/publications/) if the view is small (e.g., 430px). Related to alshedivat#1502.
Suraj-Bhor
pushed a commit
to Suraj-Bhor/suraj-bhor.github.io
that referenced
this pull request
Aug 13, 2024
This PR fixes a very niche bug. If there is a co-author that is not *me* (=`<em>` tagged) and does not have a `coauthor_url` (=`<a>` tagged), there will be a leading whitespace before the separating comma. If the author list is split into multiple lines (due to long author lists or a small view), the whitespace can lead to a line beginning with a comma. As I said, very niche, but interestingly, the other cases already did the same whitespace handling. Just the case not-me/no-url was mising. Currently, we do not have this case on vanilla al-folio, but you can see it for example on [my website](https://christianmainka.de/publications/) if the view is small (e.g., 430px). Related to alshedivat#1502.
meiqing-wang
pushed a commit
to meiqing-wang/meiqing-wang.github.io
that referenced
this pull request
Oct 13, 2024
This PR fixes a very niche bug. If there is a co-author that is not *me* (=`<em>` tagged) and does not have a `coauthor_url` (=`<a>` tagged), there will be a leading whitespace before the separating comma. If the author list is split into multiple lines (due to long author lists or a small view), the whitespace can lead to a line beginning with a comma. As I said, very niche, but interestingly, the other cases already did the same whitespace handling. Just the case not-me/no-url was mising. Currently, we do not have this case on vanilla al-folio, but you can see it for example on [my website](https://christianmainka.de/publications/) if the view is small (e.g., 430px). Related to alshedivat#1502.
avishekanand
pushed a commit
to avishekanand/al-folio-homepage
that referenced
this pull request
Oct 22, 2024
This PR fixes a very niche bug. If there is a co-author that is not *me* (=`<em>` tagged) and does not have a `coauthor_url` (=`<a>` tagged), there will be a leading whitespace before the separating comma. If the author list is split into multiple lines (due to long author lists or a small view), the whitespace can lead to a line beginning with a comma. As I said, very niche, but interestingly, the other cases already did the same whitespace handling. Just the case not-me/no-url was mising. Currently, we do not have this case on vanilla al-folio, but you can see it for example on [my website](https://christianmainka.de/publications/) if the view is small (e.g., 430px). Related to alshedivat#1502.
mattleblanc
pushed a commit
to mattleblanc/mattleblanc.github.io
that referenced
this pull request
Dec 29, 2024
This PR fixes a very niche bug. If there is a co-author that is not *me* (=`<em>` tagged) and does not have a `coauthor_url` (=`<a>` tagged), there will be a leading whitespace before the separating comma. If the author list is split into multiple lines (due to long author lists or a small view), the whitespace can lead to a line beginning with a comma. As I said, very niche, but interestingly, the other cases already did the same whitespace handling. Just the case not-me/no-url was mising. Currently, we do not have this case on vanilla al-folio, but you can see it for example on [my website](https://christianmainka.de/publications/) if the view is small (e.g., 430px). Related to alshedivat#1502.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a very niche bug.
If there is a co-author that is not me (=
<em>tagged) and does not have acoauthor_url(=<a>tagged), there will be a leading whitespace before the separating comma. If the author list is split into multiple lines (due to long author lists or a small view), the whitespace can lead to a line beginning with a comma.As I said, very niche, but interestingly, the other cases already did the same whitespace handling. Just the case not-me/no-url was mising.
Currently, we do not have this case on vanilla al-folio, but you can see it for example on my website if the view is small (e.g., 430px).
Related to #1502.