UI cleanup (improved ambassador buttons/cards/list, SVG icons) #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
MattIPv4
commented
Oct 8, 2023
•
MattIPv4
commented
- Full-width image on ambassador cards/buttons
- Misc. ambassador card clean up
- Better fade on ambassador list overlay
- Use SVG icons for more things, less rasters
MattIPv4
changed the title
|
My only concern with this is the ambassador name overlay on the image in the cards -- I've added a bit of logic to offset the images where we can, and when hovering on the image the name fades away, but it's still not perfect. That being said, I think it looks a lot better than having the name elsewhere. |
pjeweb
reviewed
Oct 8, 2023
pjeweb
approved these changes
Oct 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.