Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't fullscreen the video when double-clicking components #144

Merged
merged 5 commits into from
Oct 31, 2023
Merged

Don't fullscreen the video when double-clicking components #144

merged 5 commits into from
Oct 31, 2023

Conversation

t1m0thyj
Copy link
Contributor

Fixes #54

Since I am not a React expert and this is my first time developing a Twitch extension, I welcome any critiques 😁

I can remove cd084dc if desired, but I believe using a tool like cross-env is necessary to set env variables inline on Windows.

Copy link
Member

@MattIPv4 MattIPv4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tyvm

@MattIPv4 MattIPv4 merged commit ce13e88 into alveusgg:main Oct 31, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Double-clicking components fullscreen's the video
2 participants