Skip to content
This repository has been archived by the owner on Nov 21, 2024. It is now read-only.

Enhance Authentication #611

Merged
merged 4 commits into from
Nov 18, 2023
Merged

Enhance Authentication #611

merged 4 commits into from
Nov 18, 2023

Conversation

temparus
Copy link
Member

@temparus temparus commented Nov 18, 2023

  • Fixes the LDAP sync issue for users which are not enrolled at ETH anymore.
  • Allows for ETH members to authenticate against LDAP by using their ETH email address (Resolves Login with email address #598)

Copy link

codecov bot commented Nov 18, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (0bb8db1) 94.77% compared to head (1a52cd1) 94.76%.

Files Patch % Lines
amivapi/auth/sessions.py 57.14% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #611      +/-   ##
==========================================
- Coverage   94.77%   94.76%   -0.02%     
==========================================
  Files          75       75              
  Lines        4310     4315       +5     
==========================================
+ Hits         4085     4089       +4     
- Misses        225      226       +1     
Flag Coverage Δ
unittests 94.76% <66.66%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@suisseWalter suisseWalter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, doesn't change the behaviour for extraordinary members hat sign in with their private email, but allows eth students to sign in with their full email address. which is now common. also fixes the the issue with signins for extraordinary members, that haven't changed their email/password.

@temparus temparus merged commit 83c8efd into master Nov 18, 2023
4 of 5 checks passed
@temparus temparus deleted the 598-enhance-auth branch November 18, 2023 23:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Login with email address
2 participants