fix: sizeRem regression in v4.3.1 to transform px to rem (#1436)

amzn · Jan 21, 2025 · 7d60069 · 7d60069
1 parent 6fc68b4
commit 7d60069
Show file tree

Hide file tree

Showing 4 changed files with 212 additions and 421 deletions.
diff --git a/.changeset/clean-ligers-listen.md b/.changeset/clean-ligers-listen.md
@@ -0,0 +1,5 @@
+---
+'style-dictionary': patch
+---
+
+Hotfix for `'size/rem'` => `sizeRem` transform to not change values with `'px'` units to `'rem'`. Regression was added in `v4.3.1` (commit sha 1684a8e).
diff --git a/__tests__/common/transforms.test.js b/__tests__/common/transforms.test.js
@@ -1023,6 +1023,17 @@ describe('common', () => {
       it('should throw an error if prop value is Nan', () => {
         expect(() => transforms[sizeDp].transform({ value: 'a' }, {}, {})).to.throw();
       });
+
+      it('should not change the unit to rem if the value already has a unit', () => {
+        const value = transforms[sizeRem].transform(
+          {
+            value: '5px',
+          },
+          {},
+          {},
+        );
+        expect(value).to.equal('5px');
+      });
     });
 
     describe(sizeFlutterRemToDouble, () => {

diff --git a/lib/common/transforms.js b/lib/common/transforms.js
@@ -829,7 +829,7 @@ export default {
     transform: function (token, _, options) {
       const nonParsed = options.usesDtcg ? token.$value : token.value;
       // if the dimension already has a unit (non-digit / . period character)
-      if (`${nonParsed}`.match(/^[^0-9.-]+$/)) {
+      if (`${nonParsed}`.match(/[^0-9.-]+$/)) {
         return nonParsed;
       }
       const parsedVal = parseFloat(nonParsed);