are requirements 9, 14, 22, 23 resolved?

[mkuzak]

I think requirements 9, 14, 22, 23 has been resolved. @Nanouk123 @JAvRZ please test on running cloud instance and comment here, before I cross them out.

[Nanouk123]

had typed a large response .. closet my browser .. kill me now

Ok Im going to type them one by one ok?

Requirement 9:

I do like where the upload button is for the batch. I'm not sure I like where the download button is. Now I think we run the risk that clinicians click that prior to selecting tests and that they will try to give the variables their own names (and be frustrated if it doesnt work).

Practically we have two options.

1. making it appear below the 'selected tests' as in the same box. Also making it appear the moment they click the first test (if they can press 'download' they will draw the conclusion the templated is filled by what they've clicked).

2. In the box where the download template is now, make instructions that they FIRST have to select from the tree structure.

Also the template dld is still in .csv which also means clinicians will upload in .csv (not in xls).

[Nanouk123]

Requirement 14:

This works one way around. So if I add variables to the .csv they are correctly detected (if I use the correct variable names) and displayed in the 'Data Entry' screen.
The other way around, if I create a template based on the treestructure (so I select from the tree and press 'download') and than REMOVED a few variables (cause I decided I dont like those anyway). They are not removed from the 'Data entry screen'

Related: Is there a way that after the pop up 'Data was successfully uploaded' it moves to the next tab? Now its kinda weird. On screen nothing changes for the clinician and Im sure this will lead to confusion. (as does the label 'data entry' if you've just received the notification the upload was successful.. but we'll work on that).

[Nanouk123]

Requirement 22:

In my browser (chrome but perhaps old) I don't get the pre-printed dd/mm/yyyy in the box (yet).
Also theres no icon for the calendar which I'd like. Now if I click it it pops up (for all patients, also the ones which I've already given an age which makes the screen look very messy).

So Id like a small calendar icon next to the field. If you click that, than the calendar pops up for that patient only. I will try to find an example on a website for you.

[Nanouk123]

Requirement 23

Yes this is done for now.

[mkuzak]

@Nanouk123 about requirement 22, can you make an issue in https://github.com/andi-nl/andi-frontend for it?

[mkuzak]

@Nanouk123 in respect to comment on requirement 9:
I like the idea of making a download button show up after you select some tests.
It still csv, I need more time for xls solution.

[mkuzak]

@Nanouk123 in respect to comment on requirement 14:
this seams more complicated. We have 3 options:

1. The chosen variables are the sum of test variables selected from the tree and those uploaded from the file, in which case uploading template with deleted variable will not lead to removing them from selection.
2. Downloaded data is overwriting selection. In that case it will be impossible to fill in some online and upload some.
3. Selected data is overwriting selection. In that case you can only upload what have been selected.

I agree on moving to second tab after uploading the file. I made an issue about it

[Nanouk123]

@mkuzak I think 1) is good. It's just something I noticed. I don't think it will be highly problematic that it will display variables that are not filled out.

[mkuzak]

@Nanouk123 clear, if no one is against we should go for option one.

[Nanouk123]

We can always ask Ben and Hilde tomorrow.

[Nanouk123]

But lets just say I dont think this is the biggest problem so ignore it for now