Fix/map #1261
Merged
Fix/map #1261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Offline Maps Frontend
|
Android APK build completed! |
|
iOS IPA build completed! |
|
❌ Tests failed for this pull request. 😞 |
taronaleksanian
commented
Oct 1, 2024
| @@ -182,7 +174,7 @@ export const DestinationPage = () => { | |||
| </View> | |||
|
|
|||
| <DestinationHeader | |||
| geoJSON={geoJSON} | |||
| geojsonProperties={geojsonData.properties} | |||
There was a problem hiding this comment.
in destination page we don't save anything to db so perhaps we don't need it
|
@mikib0 we have unplanned changes with the latest commit, can you please make a new branch and include the changes we have planned? we need just a function that saves geojson data to s3. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.