-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing LBaaS ACL and rule bindings #142
Conversation
Code Climate has analyzed commit f966ae3 and detected 2 issues on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
8936067
to
1792e4b
Compare
1792e4b
to
b537f7a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if we need some changes
437691c
to
98dd396
Compare
98dd396
to
bb27ae2
Compare
7a0b558
to
3979a86
Compare
Codecov Report
@@ Coverage Diff @@
## main #142 +/- ##
==========================================
+ Coverage 51.88% 52.78% +0.89%
==========================================
Files 98 101 +3
Lines 4577 4689 +112
==========================================
+ Hits 2375 2475 +100
- Misses 1964 1972 +8
- Partials 238 242 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
extract list-filters building from Rule EndpointURL add omitempty for lbaas rules and acls
Use pkg/utils/object/filter.Helper instead
Use pointer values in LBaaS API bindings to allow omittable zero values
3979a86
to
f966ae3
Compare
Description
Checklist
Unreleased
section in CHANGELOG.md, if user facing changeReferences
Community Note