Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing LBaaS ACL and rule bindings #142

Merged
merged 3 commits into from
Jun 10, 2022

Conversation

marioreggiori
Copy link

Description

Checklist

  • added release notes to Unreleased section in CHANGELOG.md, if user facing change

References

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

@codeclimate
Copy link

codeclimate bot commented May 19, 2022

Code Climate has analyzed commit f966ae3 and detected 2 issues on this pull request.

Here's the issue category breakdown:

Category Count
Duplication 2

View more on Code Climate.

@marioreggiori marioreggiori force-pushed the SYSENG-1092/lbaas-genclient branch 2 times, most recently from 8936067 to 1792e4b Compare May 19, 2022 07:25
@marioreggiori marioreggiori force-pushed the SYSENG-1092/lbaas-genclient branch from 1792e4b to b537f7a Compare May 30, 2022 10:34
@marioreggiori marioreggiori requested a review from LittleFox94 May 30, 2022 11:04
Copy link
Contributor

@LittleFox94 LittleFox94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if we need some changes

pkg/apis/lbaas/v1/acl_types.go Outdated Show resolved Hide resolved
pkg/apis/lbaas/v1/rule_types.go Outdated Show resolved Hide resolved
@marioreggiori marioreggiori force-pushed the SYSENG-1092/lbaas-genclient branch 2 times, most recently from 437691c to 98dd396 Compare May 31, 2022 14:07
@LittleFox94 LittleFox94 force-pushed the SYSENG-1092/lbaas-genclient branch from 98dd396 to bb27ae2 Compare June 7, 2022 09:40
@marioreggiori marioreggiori marked this pull request as draft June 8, 2022 06:39
@marioreggiori marioreggiori force-pushed the SYSENG-1092/lbaas-genclient branch 2 times, most recently from 7a0b558 to 3979a86 Compare June 9, 2022 06:21
@marioreggiori marioreggiori requested a review from LittleFox94 June 9, 2022 06:25
@marioreggiori marioreggiori marked this pull request as ready for review June 9, 2022 06:42
@codecov-commenter
Copy link

Codecov Report

Merging #142 (3979a86) into main (f79a161) will increase coverage by 0.89%.
The diff coverage is 89.28%.

@@            Coverage Diff             @@
##             main     #142      +/-   ##
==========================================
+ Coverage   51.88%   52.78%   +0.89%     
==========================================
  Files          98      101       +3     
  Lines        4577     4689     +112     
==========================================
+ Hits         2375     2475     +100     
- Misses       1964     1972       +8     
- Partials      238      242       +4     
Flag Coverage Δ
integration 52.78% <89.28%> (+0.89%) ⬆️
unittests 40.71% <67.85%> (+0.71%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/apis/lbaas/v1/acl_genclient.go 82.85% <82.85%> (ø)
pkg/apis/lbaas/v1/rule_genclient.go 82.85% <82.85%> (ø)
pkg/utils/pointer/convert.go 100.00% <100.00%> (ø)
pkg/client/client.go 80.29% <0.00%> (ø)
pkg/api/types/context.go 100.00% <0.00%> (ø)
pkg/api/api_implementation.go 95.62% <0.00%> (ø)
pkg/utils/object/compare/compare.go 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f79a161...3979a86. Read the comment docs.

toothstone and others added 3 commits June 10, 2022 10:25
extract list-filters building from Rule EndpointURL

add omitempty for lbaas rules and acls
Use pkg/utils/object/filter.Helper instead
Use pointer values in LBaaS API bindings to allow omittable zero values
@marioreggiori marioreggiori force-pushed the SYSENG-1092/lbaas-genclient branch from 3979a86 to f966ae3 Compare June 10, 2022 08:25
@marioreggiori marioreggiori merged commit c6ca2d0 into main Jun 10, 2022
@marioreggiori marioreggiori deleted the SYSENG-1092/lbaas-genclient branch June 10, 2022 09:05
@marioreggiori marioreggiori mentioned this pull request Jun 10, 2022
1 task
LittleFox94 added a commit that referenced this pull request Jun 10, 2022
LittleFox94 added a commit that referenced this pull request Jun 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants