Implemented predictive back navigation for some screens #14659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BrayanDSO
added
the
Needs Second Approval
The added back callback is enabled/disabled based on webview status( can go back or not) to let the system know if it should handle the back navigation request. The callback is disabled at start, the WebView it's expected to not have any history yet. See: https://codelabs.developers.google.com/handling-gesture-back-navigation#5 where this exact scenario is handled.
The previous code was setting the result on back pressed passing the values of two class properties, the modified code sets an initial result + updates the returned Intent every time one of the observed properties is changed.
Simply deleted the onBackPressed() callback as all it did was to close the activity. Without a back callbak set, the system will handle the back navigation itself. The toolbar home button was already handled in the superclass AnkiActivity.
lukstbit
force-pushed
the
feat_predictiveBackNavigation
branch
from
be776c3 to
ff873ea
Compare
david-allison
approved these changes
Nov 9, 2023
github-actions
bot
removed
the
Needs Second Approval
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose / Description
Implemented predictive back navigation for Info.kt, ModelFieldEditor.kt and Previewer.kt. These are the simplest screens to change, with a note on Info.kt if we really need to handle the WebView.canGoBack() as we start an outside browser for any url.
Info.kt:
info.mp4
Previewer.kt:
previewer.mp4
ModelFieldEditor.kt:
modelfieldeditor.mp4
Fixes
Related to #14558
How Has This Been Tested?
Enabled the predictive back navigation and manually tested the changed screens
Checklist