Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: today stats overflow #16965

Closed
wants to merge 1 commit into from
Closed

Conversation

MorenoTropical
Copy link
Contributor

Fixes

Approach

I made it multi-line

How Has This Been Tested?

Increased the device font size and took a screenshot

overflow

Checklist

Please, go through these checks before submitting the PR.

  • You have a descriptive commit message with a short title (first line, max 50 chars).
  • You have commented your code, particularly in hard-to-understand areas
  • You have performed a self-review of your own code
  • UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
  • UI Changes: You have tested your change using the Google Accessibility Scanner

@lukstbit
Copy link
Member

A fix for that issue should use WindowInsets to handle phones with rounded corners and the bottom drag bar disabled.

@MorenoTropical
Copy link
Contributor Author

A fix for that issue should use WindowInsets to handle phones with rounded corners and the bottom drag bar disabled.

I tried and looked at WindowInsets, but the problem happens despite of the screen having rounded corners or not, like when the device font size is set to big

@lukstbit
Copy link
Member

lukstbit commented Sep 8, 2024

I don't think this is the proper fix, making it multi line might work when the text is bigger but it isn't going to work if the text barely fits in one line and gets near the edges and the screen. I still think WindowInsets should be used especially as edge to edge will become the default with Android 15.

@lukstbit lukstbit added the Needs Author Reply Waiting for a reply from the original author label Sep 8, 2024
Copy link
Contributor

Hello 👋, this PR has had no activity for more than 2 weeks and needs a reply from the author. If you think this is a mistake please comment and ping a maintainer to get this merged ASAP! Thanks for contributing! You have 7 days until this gets closed automatically

@Arthur-Milchior
Copy link
Member

@lukstbit the link is dead. Medium suspended the account. Any other link you'd get please?

@lukstbit
Copy link
Member

lukstbit commented Nov 4, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Author Reply Waiting for a reply from the original author Stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG]: String of review count at bottom of deck picker screen overflows
3 participants