-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix onBackPressed deprecation of CardTemplateEditor #17599
fix onBackPressed deprecation of CardTemplateEditor #17599
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good.
One extra thing left over is a call in CardTemplateEditor's _onOptionsItemSelected()_method to the deprecated onBackPressed() that should be replaced with:
onBackPressedDispatcher.onBackPressed()
b488890
to
6086474
Compare
6086474
to
4e5c018
Compare
4e5c018
to
a248373
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, cheers!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for making the changes.
Hi there @Prince-kushwaha! This is the OpenCollective Notice for PRs merged from 2024-12-01 through 2024-12-31 If you are interested in compensation for this work, the process with details is here: https://github.com/ankidroid/Anki-Android/wiki/OpenCollective-Payment-Process#how-to-get-paid Important PLEASE NOTE: The process was updated in August 2024. Re-read the Payment Process page if you have not already. We only post one comment per person per month to avoid spamming you, regardless of the number of PRs merged, but this note applies to all PRs merged for this month Please understand that our monthly budget is never guaranteed to cover all claims - the cap on payments-per-person may be lower, but we try to make our process as fair and transparent as possible, we just need your understanding. Thanks! |
Purpose / Description
fix onBackPressed deprecation of CardTemplateEditor
Fixes
How Has This Been Tested?
Physical Device
Checklist
Please, go through these checks before submitting the PR.