Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: show snackbar if no data connection in shared deck download #17720

Merged
merged 1 commit into from
Jan 5, 2025

Conversation

criticalAY
Copy link
Contributor

Purpose / Description

Dont open the webview in case no network is detected and show a snackbar instead

How Has This Been Tested?

Locally API 35

Checklist

Please, go through these checks before submitting the PR.

  • You have a descriptive commit message with a short title (first line, max 50 chars).
  • You have commented your code, particularly in hard-to-understand areas
  • You have performed a self-review of your own code
  • UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
  • UI Changes: You have tested your change using the Google Accessibility Scanner

Copy link
Member

@david-allison david-allison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good.

A HUGE win would be to introduce this while syncing. We previously had really good online/offline detection, but this was lost on the upgrade of the sync code to use the new backend

@david-allison david-allison added the Needs Second Approval Has one approval, one more approval to merge label Jan 5, 2025
Copy link
Member

@BrayanDSO BrayanDSO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same request of David

@BrayanDSO BrayanDSO added Needs Author Reply Waiting for a reply from the original author Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) and removed Needs Second Approval Has one approval, one more approval to merge labels Jan 5, 2025
@david-allison
Copy link
Member

david-allison commented Jan 5, 2025

I don't believe I have a request here which warrants an author reply. I'd rather a new issue/PR rather than 'piling on' to this PR with a larger request

I've clarified my comment, which was intended as documentation, rather than a request

@criticalAY
Copy link
Contributor Author

Can we remove the author reply label

@david-allison david-allison removed the Needs Author Reply Waiting for a reply from the original author label Jan 5, 2025
@david-allison david-allison added this pull request to the merge queue Jan 5, 2025
Merged via the queue into ankidroid:main with commit 5ff3c18 Jan 5, 2025
12 checks passed
@github-actions github-actions bot removed the Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) label Jan 5, 2025
@github-actions github-actions bot added this to the 2.21 release milestone Jan 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants