Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: flag color in new reviewer #17724

Merged
merged 1 commit into from
Jan 6, 2025
Merged

Conversation

RobozinhoD
Copy link
Contributor

Purpose / Description

Describe the problem or feature and motivation

the new reviewer "Flag.NONE" icon had a different color because it wasn't using the new property drawableReviewerRes introduced in #17434

Screenshot of the issue

issue

Approach

I solved the TODO of Flag.kt and used colorControlNormal everywhere.

How Has This Been Tested?

Screenshots

browser (1)
browser (3)
browser (4)
new reviewer
reviewer
reviewer2
reviewer3

Checklist

Please, go through these checks before submitting the PR.

  • You have a descriptive commit message with a short title (first line, max 50 chars).
  • You have commented your code, particularly in hard-to-understand areas
  • You have performed a self-review of your own code
  • UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
  • UI Changes: You have tested your change using the Google Accessibility Scanner

the new reviewer "Flag.NONE" icon had a different color because it wasn't using `drawableReviewerRes`

I added the flag items back to the XML so I could change only the Flag.NONE icon
Copy link
Member

@mikehardy mikehardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔 seems right

@mikehardy mikehardy added UI Needs Second Approval Has one approval, one more approval to merge labels Jan 6, 2025
Copy link
Member

@david-allison david-allison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, custom names are maintained

@david-allison david-allison added this pull request to the merge queue Jan 6, 2025
Merged via the queue into ankidroid:main with commit 1a96697 Jan 6, 2025
12 checks passed
@github-actions github-actions bot added this to the 2.21 release milestone Jan 6, 2025
@github-actions github-actions bot removed the Needs Second Approval Has one approval, one more approval to merge label Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants