Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: study options opening old reviewer #17726

Merged
merged 1 commit into from
Jan 6, 2025

Conversation

RobozinhoD
Copy link
Contributor

@RobozinhoD RobozinhoD commented Jan 5, 2025

Fixes

Approach

  • Search for Reviewer::class.java uses
  • Replace most of them (the only one left defaults to the new reviewer as well)

How Has This Been Tested?

  • Open the study options screen
  • Tap study
  • The new reviewer shows up (before this fix, the old reviewer was shown)

Checklist

Please, go through these checks before submitting the PR.

  • You have a descriptive commit message with a short title (first line, max 50 chars).
  • You have commented your code, particularly in hard-to-understand areas
  • You have performed a self-review of your own code
  • UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
  • UI Changes: You have tested your change using the Google Accessibility Scanner

All the places that launched the Reviewer class now check if they should launch the new reviewer
Copy link
Member

@david-allison david-allison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, thanks!!

Note: I updated the 'fixed' issue to #17714 in the PR description

@david-allison david-allison added the Needs Second Approval Has one approval, one more approval to merge label Jan 5, 2025
Copy link
Member

@mikehardy mikehardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The user experiencing this was my wife 😆 - she will be pleased
Thank you!

@mikehardy mikehardy added this pull request to the merge queue Jan 6, 2025
@mikehardy mikehardy added Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) and removed Needs Second Approval Has one approval, one more approval to merge labels Jan 6, 2025
Merged via the queue into ankidroid:main with commit 0b49ad1 Jan 6, 2025
12 checks passed
@github-actions github-actions bot removed the Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) label Jan 6, 2025
@github-actions github-actions bot added this to the 2.21 release milestone Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dev - new reviewer state does not apply at all expected times
3 participants