Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: toggle auto advance in new reviewer #17729

Merged
merged 1 commit into from
Jan 6, 2025

Conversation

RobozinhoD
Copy link
Contributor

it also changes the behavior to match the desktop code, so auto advance only starts after the user toggles it

Fixes

How Has This Been Tested?

Nothing.webm
more.webm

Checklist

Please, go through these checks before submitting the PR.

  • You have a descriptive commit message with a short title (first line, max 50 chars).
  • You have commented your code, particularly in hard-to-understand areas
  • You have performed a self-review of your own code
  • UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
  • UI Changes: You have tested your change using the Google Accessibility Scanner

it also changes the behavior to match the desktop code, so auto advance only starts after the user toggles it
Copy link
Member

@BrayanDSO BrayanDSO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'm okay with using the desktop approach of only start auto advance after it is enabled.

I'm also okay with to enable it by default, which feels more natural and practical, but I'm not strong enough about it to diverge from the desktop version.

Anyway, this is a developer option and it is not worth to block it because of that. Changing it takes only 30 seconds, and discussions sometimes take 30 days.

Furthermore, there are a lot of scenarios related to auto advance. Some @NeedsTest would be nice

@BrayanDSO BrayanDSO added the Needs Second Approval Has one approval, one more approval to merge label Jan 6, 2025
Copy link
Member

@mikehardy mikehardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also LGTM, I prefer not to deviate from desktop at all personally so wouldn't do so here

not sure where I'd concretely suggest a NeedsTest except everywhere which is then not really specific and matches rest of code base

@mikehardy mikehardy added this pull request to the merge queue Jan 6, 2025
Merged via the queue into ankidroid:main with commit 3d26bc5 Jan 6, 2025
12 checks passed
@github-actions github-actions bot added this to the 2.21 release milestone Jan 6, 2025
@github-actions github-actions bot removed the Needs Second Approval Has one approval, one more approval to merge label Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants