NF: transform object to data object #17730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As requested by David in a recent PR adding enum in consts. I looked for all obejcts in sealed class/interface. I didn't touch object, even if named, that are not part of a sealed class/interface, as it's not clear that it's a big deal if `toString` does not show their name.
david-allison
approved these changes
Jan 6, 2025
|
Just for clarity: I didn't request that you went through the codebase, but it's still a much welcome change! Thanks! |
david-allison
added
Needs Second Approval
mikehardy
added
Pending Merge
github-actions
bot
removed
the
Pending Merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As requested by David in a recent PR adding enum in consts. I looked for all obejcts in sealed class/interface. I didn't touch object, even if named, that are not part of a sealed class/interface, as it's not clear that it's a big deal if
toStringdoes not show their name.