Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow tinting 'tick' icon #17735

Merged
merged 1 commit into from
Jan 6, 2025

Conversation

david-allison
Copy link
Member

I found it hard to find, so added some greppable strings

It also was not tintable, which made it invisible in any Material3 dialogs using it

Testing: unchanged
Screenshot 2025-01-06 at 03 19 54

Testing: now working
Screenshot 2025-01-06 at 03 21 22

Checklist

  • You have a descriptive commit message with a short title (first line, max 50 chars).
  • You have commented your code, particularly in hard-to-understand areas
  • You have performed a self-review of your own code
  • UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
  • UI Changes: You have tested your change using the Google Accessibility Scanner

@lukstbit lukstbit added Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) and removed Needs Review labels Jan 6, 2025
@lukstbit lukstbit added this pull request to the merge queue Jan 6, 2025
Merged via the queue into ankidroid:main with commit 58ecab7 Jan 6, 2025
12 checks passed
@github-actions github-actions bot added this to the 2.21 release milestone Jan 6, 2025
@github-actions github-actions bot removed the Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) label Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants