Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(new reviewer): box frame style #17746

Merged
merged 1 commit into from
Jan 7, 2025
Merged

feat(new reviewer): box frame style #17746

merged 1 commit into from
Jan 7, 2025

Conversation

BrayanDSO
Copy link
Member

@BrayanDSO BrayanDSO commented Jan 6, 2025

Purpose / Description

Anki's Webview frame is a rectangle stretched to the window borders, while the new reviewer has a nice Card like frame, which is more aesthetical.

Given that many card templates were created based on Anki's default frame, the Card style may not suit them well (e.g. by using a card template on the card frame, so the style ends up duplicated).

So, this PR gives an option to switch to the old frame, used by Anki and the old reviewer.

How Has This Been Tested?

Screenshots

Screenshot_20250106_201022

Box

Card

Checklist

Please, go through these checks before submitting the PR.

  • You have a descriptive commit message with a short title (first line, max 50 chars).
  • You have commented your code, particularly in hard-to-understand areas
  • You have performed a self-review of your own code
  • UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
  • UI Changes: You have tested your change using the Google Accessibility Scanner

Copy link
Contributor

github-actions bot commented Jan 6, 2025

Important

Maintainers: This PR contains Strings changes

  1. Sync Translations before merging this PR and wait for the action to complete
  2. Review and merge the auto-generated PR in order to sync all user-submitted translations
  3. Sync Translations again and merge the PR so the huge automated string changes caused by merging this PR are by themselves and easy to review

@BrayanDSO BrayanDSO added Needs Second Approval Has one approval, one more approval to merge Needs Review and removed Needs Second Approval Has one approval, one more approval to merge labels Jan 6, 2025
Copy link
Member

@david-allison david-allison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, nothing blocking

@david-allison david-allison added Needs Second Approval Has one approval, one more approval to merge and removed Needs Review labels Jan 6, 2025
Copy link
Member

@lukstbit lukstbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@lukstbit lukstbit added Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) and removed Needs Second Approval Has one approval, one more approval to merge labels Jan 7, 2025
@lukstbit lukstbit added this pull request to the merge queue Jan 7, 2025
Merged via the queue into ankidroid:main with commit 4180c93 Jan 7, 2025
9 checks passed
Copy link
Contributor

github-actions bot commented Jan 7, 2025

Maintainers: Please Sync Translations to produce a commit with only the automated changes from this PR.

Read more about updating strings on the wiki,

@github-actions github-actions bot removed the Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) label Jan 7, 2025
@github-actions github-actions bot added this to the 2.21 release milestone Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants