-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(new reviewer): box frame style #17746
Conversation
Important Maintainers: This PR contains Strings changes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, nothing blocking
AnkiDroid/src/main/java/com/ichi2/anki/ui/windows/reviewer/ReviewerFragment.kt
Show resolved
Hide resolved
AnkiDroid/src/main/java/com/ichi2/anki/ui/windows/reviewer/ReviewerFragment.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Maintainers: Please Sync Translations to produce a commit with only the automated changes from this PR. Read more about updating strings on the wiki, |
Purpose / Description
Anki's Webview frame is a rectangle stretched to the window borders, while the new reviewer has a nice
Card
like frame, which is more aesthetical.Given that many card templates were created based on Anki's default frame, the
Card
style may not suit them well (e.g. by using a card template on the card frame, so the style ends up duplicated).So, this PR gives an option to switch to the old frame, used by Anki and the old reviewer.
How Has This Been Tested?
Screenshots
Checklist
Please, go through these checks before submitting the PR.