Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improvement(browser-options): fix casing of title #17764

Merged
merged 1 commit into from
Jan 8, 2025

Conversation

david-allison
Copy link
Member

@david-allison david-allison commented Jan 8, 2025

How Has This Been Tested?

Screenshot 2025-01-08 at 01 18 32 Screenshot 2025-01-08 at 01 18 32

Checklist

  • You have a descriptive commit message with a short title (first line, max 50 chars).
  • You have commented your code, particularly in hard-to-understand areas
  • You have performed a self-review of your own code
  • UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
  • UI Changes: You have tested your change using the Google Accessibility Scanner

@david-allison david-allison changed the title improvement(deck-options): fix casing of title improvement(browser-options): fix casing of title Jan 8, 2025
Copy link
Member

@mikehardy mikehardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't get it...if we're not fixing the sentence case on something outside of our control (stuff from Anki-Android-Backend / anki upstream), and we're only changing the English one...changing the English value in the strings xml doesn't force a re-translate as far as I know. It's the delete + create-new-key that makes a retranslate but just changing a string value in source file - I don't think that perturbs other languages?

@david-allison
Copy link
Member Author

david-allison commented Jan 8, 2025

I don't get it...if we're not fixing the sentence case on something outside of our control (stuff from Anki-Android-Backend / anki upstream), and we're only changing the English one...changing the English value in the strings xml doesn't force a re-translate as far as I know. It's the delete + create-new-key that makes a retranslate but just changing a string value in source file - I don't think that perturbs other languages?

I don't believe this is the case. I believe just changing the value forces a retranslation

Action: let's test & document this? I had a quick search and this came up blank

@lukstbit
Copy link
Member

lukstbit commented Jan 8, 2025

Already tested. In #17756 there was a string change without a key change and resulted in the string requiring translation after syncing in #17766

@lukstbit lukstbit added Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) and removed Needs Review labels Jan 8, 2025
@lukstbit lukstbit added this pull request to the merge queue Jan 8, 2025
Merged via the queue into ankidroid:main with commit f5b4aa8 Jan 8, 2025
9 checks passed
Copy link
Contributor

github-actions bot commented Jan 8, 2025

Maintainers: Please Sync Translations to produce a commit with only the automated changes from this PR.

Read more about updating strings on the wiki,

@github-actions github-actions bot removed the Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) label Jan 8, 2025
@github-actions github-actions bot added this to the 2.21 release milestone Jan 8, 2025
@mikehardy
Copy link
Member

Already tested. In #17756 there was a string change without a key change and resulted in the string requiring translation after syncing in #17766

@lukstbit ah ha! Okay then, evicting that incorrect non-fact from my head. Thanks.

@david-allison david-allison deleted the options-title branch January 8, 2025 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants