refactor(browse): lint #17805
Merged
refactor(browse): lint #17805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukstbit
requested changes
Jan 13, 2025
lukstbit
added
Needs Author Reply
david-allison
added
Needs Review
cleanup
|
Glad I did this, I didn't realize Android Studio lint wasn't working correctly for me, sorry for the hassle. |
david-allison
force-pushed
the
refactor-minor
branch
from
0a8f37f to
99aac03
Compare
lukstbit
approved these changes
Jan 14, 2025
| @@ -858,7 +858,6 @@ open class CardBrowser : | |||
| Timber.w(e, "Error Opening Note Editor") | |||
| showSnackbar( | |||
| R.string.multimedia_editor_something_wrong, | |||
| Snackbar.LENGTH_LONG, | |||
There was a problem hiding this comment.
showSnackbar() could be written in one row now.
There was a problem hiding this comment.
lint likes this style, so additional lines can be added with a single line change
lukstbit
added
Needs Second Approval
This causes the following error as Android Studio doesn't have SQL syntax highlighting ``` id, name or spec expected, got 'select min(due)' ``` https://issuetracker.google.com/issues/377733398
david-allison
force-pushed
the
refactor-minor
branch
from
99aac03 to
9ca31c8
Compare
mikehardy
added
Pending Merge
github-actions
bot
removed
the
Pending Merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a few IDE lint warnings (
.isEmpty()needed a [Mutable]Map, rather than a HashMap)I did a very quick test of the saved searched functionality, and trusting CI for the rest
Checklist