-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(deck-options): progress dialog for Optimize #17810
Conversation
Percentage was incorrectly generated as an Int
The optimizing presets message is technically incorrect. The parameters have been already optimized. It's just about the memory states of the cards being updated using the new parameters. The optimizing presets message is appropriate for the optimize all presets button, though. Here is the Anki code for reference: |
@user1823 that's what I get for trying this without a reference image 😁 Then again, it led to a bugfix, and it's one of those "5 minute" changes to fix Thanks for the guidance! |
for better documentation
`computeFsrsParams` now uses the same output as `updateDeckConfigsRaw` * move from a collection to a UI method Fixes 16642
b1cc7cb
to
a93aad7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice
Fixes
Approach
updateDeckConfigsRaw
How Has This Been Tested?
old
Checklist