change mouse icon to hand icon, make osd item have grab icon when in … #37
Conversation
…mouse mode, update css to work with different size svg icons
| @@ -6,8 +6,12 @@ | |||
| background-color:transparent; | |||
| border-radius:4px; | |||
| padding:8px; | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
This change causes the problem that all toolbar icons become oversized. Can you change back, so that standard size is retained?
There was a problem hiding this comment.
I am not sure I understand. I changed this because if you make the button width/height 45px and the svg 100% you get different sized svgs with the icons. I also found that if you use the label option it gets cut off by setting button sizing. I checked and the icons right with this css. Maybe it's down to browser? Can you expand on what oversized icons look like? or a screenshot? Thanks!
There was a problem hiding this comment.
The icons are bigger after the PR - see below. Also, I'm wondering if applying fixed width + height to SVG icons with non-square aspect ratio will work without distorting them. (But it seems so... at least trying in Chrome.) Perhaps it's just a matter of adjusting the size to less than 45px. The button has an 8px padding, so probably taking that into account is all that's needed?
vs.
|
|
||
| svg.innerHTML = | ||
| `<g> | ||
| <path d="M0 55.2V426c0 12.2 9.9 22 22 22c6.3 0 12.4-2.7 16.6-7.5L121.2 346l58.1 116.3c7.9 15.8 27.1 22.2 42.9 14.3s22.2-27.1 14.3-42.9L179.8 320H297.9c12.2 0 22.1-9.9 22.1-22.1c0-6.3-2.7-12.3-7.4-16.5L38.6 37.9C34.3 34.1 28.9 32 23.2 32C10.4 32 0 42.4 0 55.2z"/> | ||
| <!--! Font Awesome Pro 6.4.0 by @fontawesome - https://fontawesome.com License - https://fontawesome.com/license (Commercial License) Copyright 2023 Fonticons, Inc. --> |
There was a problem hiding this comment.
I'm not too familiar with the Font Awesome licensing options. But this looks like it was part of a purchased Pro package? I can only include fully openly licensed things in Annotorious. Is there an alternative icon?
There was a problem hiding this comment.
This shouldn't be part of the pro package. I don't have access to that. https://fontawesome.com/search?q=hand&o=r&m=free. That is the second icon. I am not sure why the SVG includes the "pro" in there.
…mouse mode, update css to work with different size svg icons