Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use picture thumbnails (#23) #24

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

c8e4d2a
Copy link

@c8e4d2a c8e4d2a commented May 31, 2021

No description provided.

@anon-real
Copy link
Owner

@c8e4d2a How about getting gifs from the original source for now and later when you find a way to compress them properly in the server, get the compressed one?

@c8e4d2a
Copy link
Author

c8e4d2a commented Jun 2, 2021

@c8e4d2a How about getting gifs from the original source for now and later when you find a way to compress them properly in the server, get the compressed one?

Yes. Updated PR with037c020.

@anon-real
Copy link
Owner

anon-real commented Jun 2, 2021

@c8e4d2a I see two problems:
1- For some artworks it says "not found" until it is fully loaded. It is not desired I think because people will think there is no image attacked to the NFT. Previously it showed images as they were loading.
2- Please take a look at this for example: http://localhost:3000/#/auction/specific/5e0b26c3e6ded5b21ce9ea4f1bc4792545ce128a09ee04e9a58dfaad5f6ba1ab seems to have some kind of problem.

@c8e4d2a
Copy link
Author

c8e4d2a commented Jun 2, 2021

@c8e4d2a I see two problems:
1- For some artworks it says "not found" until it is fully loaded. It is not desired I think because people will think there is no image attacked to the NFT. Previously it showed images as they were loading.
2- Please take a look at this for example: http://localhost:3000/#/auction/specific/5e0b26c3e6ded5b21ce9ea4f1bc4792545ce128a09ee04e9a58dfaad5f6ba1ab seems to have some kind of problem.

great catch, had to clear cache to reproduce, will work on an improvement

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants