enhancement: add shell completions for molecule #509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
syaghoubi00
changed the title
Signed-off-by: Sebastian Yaghoubi <[email protected]>
syaghoubi00
force-pushed
the
feat-molecule-completions
branch
from
e9c15f1 to
1ab069c
Compare
ssbarnea
approved these changes
Jan 8, 2025
ssbarnea
requested changes
Jan 8, 2025
Signed-off-by: Sebastian Yaghoubi <[email protected]>
|
I went ahead and added a test for the completions as requested. It was my first foray into writing a I wasn't sure on the best approach for testing the completions, since I was thinking there might have to be some user input simulation to try to recreate tab completion. I ended up just checking if the completion function was available, however, this is an indirect test. It should be easy to include more completions to test for, in the event more are added in the future. But they would need to be in the form that is read by the |
- pydoclint-DOC502: Remove the Raise section in the docstring since it wasn't an explicit raise condition -pylint-W0621: Don't rename scopes Signed-off-by: Sebastian Yaghoubi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add shell completion for
molecule, as it does not use flags that are picked up byargcomplete. Includes tests for added completions and the ability to test future completion additions.