fix test and change output directory #660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #660 +/- ##
==========================================
- Coverage 60.67% 58.67% -2.00%
==========================================
Files 26 26
Lines 5551 5551
==========================================
- Hits 3368 3257 -111
- Misses 2183 2294 +111
... and 3 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Autoparallel
approved these changes
Oct 27, 2023
Comment on lines
-112
to
-131
| if-no-files-found: error | ||
|
|
||
| deploy: | ||
| # Only deploy if a push to main | ||
| if: github.ref_name == 'main' && github.event_name == 'push' | ||
| runs-on: ubuntu-latest | ||
| needs: [test, lint, build] | ||
|
|
||
| # Grant GITHUB_TOKEN the permissions required to make a Pages deployment | ||
| permissions: | ||
| pages: write | ||
| id-token: write | ||
|
|
||
| environment: | ||
| name: github-pages | ||
| url: ${{ steps.deployment.outputs.page_url }} | ||
|
|
||
| steps: | ||
| - name: Deploy to GitHub Pages | ||
| id: deployment |
There was a problem hiding this comment.
What all is being removed here?
There was a problem hiding this comment.
This is removing the deploy job for the book that we never run because our mdbook isn't deployed to github pages (yet)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #657 and fixes tests