AIP-72: Port _validate_inlet_outlet_assets_activeness into Task SDK #46020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amoghrajesh
requested review from
ephraimbuddy,
pierrejeambrun,
XD-DENG and
ashb
as code owners
|
Need to work on few things:
|
ashb
reviewed
Jan 24, 2025
| task_instance = session.scalar(select(TI).where(TI.id == ti_id_str)) | ||
| if task_instance.state != State.RUNNING: | ||
| return Response(status_code=status.HTTP_204_NO_CONTENT) | ||
| else: |
There was a problem hiding this comment.
Nit: Since the if block returns there is no need for the else.
As a general rule if you can have something less indented it is better. (Or to put it another way, the deeper nested the code is, the more complex it is.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.