Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds the bookie cookie service for http api #4541

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

SongOf
Copy link

@SongOf SongOf commented Dec 30, 2024

Descriptions of the changes in this PR:

Motivation
It would be convenient to support get, or delete the cookie of bookie with REST API, just like what does in the shell command.

Changes
Adds an API to get, delete the cookie of bookie at /api/v1/bookie/cookie.

@congbobo184
Copy link
Contributor

@zymap @eolivelli @hangc0276 @horizonzy please help review this pr, thanks.

@liangyuanpeng
Copy link

liangyuanpeng commented Dec 31, 2024

@SongOf
Copy link
Author

SongOf commented Dec 31, 2024

seems like it is working for BP-68

seems like it is working for BP-68

Yes, there are two http apis. But both are used to delete the decommissioned bookie's cookie information. BP-68 will delete cookie as part of decommission API. This API("/api/v1/bookie/cookie") is invoked by the operation and maintenance platform to delete cookies after detecting that the bookie is decommissioned.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants