Simplify - only macOS now needs library override #663
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| # Licensed to the Apache Software Foundation (ASF) under one or more | |
| # contributor license agreements. See the NOTICE file distributed with | |
| # this work for additional information regarding copyright ownership. | |
| # The ASF licenses this file to You under the Apache License, Version 2.0 | |
| # (the "License"); you may not use this file except in compliance with | |
| # the License. You may obtain a copy of the License at | |
| # | |
| # http://www.apache.org/licenses/LICENSE-2.0 | |
| # | |
| # Unless required by applicable law or agreed to in writing, software | |
| # distributed under the License is distributed on an "AS IS" BASIS, | |
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | |
| # See the License for the specific language governing permissions and | |
| # limitations under the License. | |
| name: Java CI | |
| # cross-build tests are done in a separate action as they currrently take a long time | |
| on: | |
| # allow direct trigger | |
| workflow_dispatch: | |
| push: | |
| paths-ignore: | |
| - '**/workflows/*.yml' | |
| - 'src/docker/*' | |
| - '!**/workflows/maven.yml' | |
| pull_request: | |
| paths-ignore: | |
| - '**/workflows/*.yml' | |
| - 'src/docker/*' | |
| - '!**/workflows/maven.yml' | |
| permissions: | |
| contents: read | |
| jobs: | |
| build: | |
| runs-on: ${{ matrix.os }} | |
| continue-on-error: ${{ matrix.experimental }} | |
| strategy: | |
| matrix: | |
| os: [macos-11, ubuntu-20.04, windows-latest] | |
| java: [ 8, 11, 17, 21 ] | |
| experimental: [false] | |
| # macos-13-arm64 does not appear to be available | |
| # include: | |
| # - java: 21 | |
| # os: macos-13-arm64 | |
| # experimental: true | |
| include: | |
| - os: macos-latest | |
| java: 8 | |
| experimental: false | |
| - os: ubuntu-latest | |
| java: 8 | |
| experimental: false | |
| # - java: 22-ea | |
| # os: ubuntu-20.04 | |
| # experimental: true | |
| # - java: 22-ea | |
| # os: windows-latest | |
| # experimental: true | |
| # - java: 22-ea | |
| # os: macos-latest | |
| # experimental: true | |
| # We don't need to build all Java versions every time | |
| # Try excluding 11, 17 on branch pushes | |
| exclude: | |
| - java: ${{ (github.ref != 'refs/heads/master' && github.event_name == 'push') && 11 || 99 }} | |
| - java: ${{ (github.ref != 'refs/heads/master' && github.event_name == 'push') && 17 || 99 }} | |
| fail-fast: false | |
| steps: | |
| - uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1 | |
| with: | |
| persist-credentials: false | |
| - uses: actions/cache@704facf57e6136b1bc63b828d79edcd491f0ee84 # v3.3.2 | |
| with: | |
| path: ~/.m2/repository | |
| key: ${{ runner.os }}-maven-${{ hashFiles('**/pom.xml') }} | |
| restore-keys: | | |
| ${{ runner.os }}-maven- | |
| - name: Set up JDK ${{ matrix.java }} | |
| uses: actions/setup-java@0ab4596768b603586c0de567f2430c30f5b0d2b0 # v3.13.0 | |
| with: | |
| distribution: 'temurin' | |
| java-version: ${{ matrix.java }} | |
| - name: OpenSSL version (default) | |
| run: openssl version -a | |
| - name: OpenSSL engine (macOS) | |
| # need to override the libarary path on macOS to avoid 'unsafe load' complaint | |
| if: ${{ runner.os == 'macOS' }} | |
| run: | | |
| echo $(openssl version -e | sed -n -e 's/engines-.*//' -e 's/: "/=/p') >> "$GITHUB_ENV" | |
| - name: Build with Maven (skip tests) | |
| # OPENSSL_HOME is needed for Windows build to find some header files | |
| # It's not clear how one is supposed to find the correct setting; | |
| # The value below was found by searching for openssl files under C (warning: slow) | |
| # Other possible values are: | |
| # "C:\\Miniconda\\pkgs\\openssl-1.1.1n-h2bbff1b_0\\Library" | |
| # "C:\\ProgramData\\chocolatey\\lib\\mingw\\tools\\install\\mingw64\\opt" | |
| # N.B. This must *not* be run under the bash shell, as that changes the default openssl library under Windows | |
| env: | |
| OPENSSL_HOME: "C:\\Miniconda\\Library" | |
| run: | | |
| mvn -V -B -ntp -DskipTests | |
| - name: Test with Maven (macOS) | |
| # macOS needs to override the library name | |
| if: ${{ runner.os == 'macOS' }} | |
| # Show the defaults after the main run (will likely fail with unsafe load) | |
| run: | | |
| mvn -V -B -ntp surefire:test -DtrimStackTrace=false -Djni.library.path=$ENGINESDIR -Djna.library.path=$ENGINESDIR | |
| mvn -V -B -ntp surefire:test -D"test=CryptoTest,OpenSslJnaTest" || true | |
| - name: Test with Maven (not macOS) | |
| if: ${{ runner.os != 'macOS' }} | |
| run: | | |
| mvn -V -B -ntp surefire:test -DtrimStackTrace=false | |
| - name: Check benchmark code compiles | |
| if: ${{ matrix.java == '8' }} | |
| env: | |
| OPENSSL_HOME: "C:\\Miniconda\\Library" | |
| run: | | |
| mvn -V -B -ntp clean test-compile -Pbenchmark | |
| - name: Check JNI and JNA tests are independent | |
| # No need to test on all OS/Java combinations | |
| if: ${{ matrix.java == '8' && runner.os == 'Ubuntu' }} | |
| run: | | |
| mvn -V -B -ntp test -Ptestjni -Dcommons.crypto.OpenSslNativeJna=___ | |
| mvn -V -B -ntp test -Ptestjna -Dcommons.crypto.OpenSslNativeJni=___ |