-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
extract expressions to folders based on spark grouping #1206
base: main
Are you sure you want to change the base?
Conversation
Thanks @rluvaton. This is a good idea. |
Thanks @andygrove, The PR is now ready, I moved all the functions to the correct location |
Awesome. I plan on reviewing this later this week. |
@rluvaton I think that this looks great but it is challenging to really review the PR with so many changes. What do you think about breaking this down into some smaller PRs that are easier to review? For example, maybe the first PR just moves string expressions. |
No problem |
Rationale for this change
Making it easier to find functions and add stuff at the right location
the sub folder name are named after Spark
ExpressionDescription
group
propertyWhat changes are included in this PR?
just reorder files and extract functions there are no logic changes
How are these changes tested?
Existing tests