Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extract expressions to folders based on spark grouping #1206

Open
wants to merge 19 commits into
base: main
Choose a base branch
from

Conversation

rluvaton
Copy link
Contributor

@rluvaton rluvaton commented Dec 29, 2024

Rationale for this change

Making it easier to find functions and add stuff at the right location

the sub folder name are named after Spark ExpressionDescription group property

image

What changes are included in this PR?

just reorder files and extract functions there are no logic changes

How are these changes tested?

Existing tests

@andygrove
Copy link
Member

Thanks @rluvaton. This is a good idea.

@rluvaton rluvaton changed the title extract strings file to strings_func like in spark grouping extract expressions to folders based on spark grouping Dec 30, 2024
@rluvaton rluvaton marked this pull request as ready for review December 30, 2024 12:09
@rluvaton
Copy link
Contributor Author

Thanks @andygrove, The PR is now ready, I moved all the functions to the correct location

@andygrove
Copy link
Member

Thanks @andygrove, The PR is now ready, I moved all the functions to the correct location

Awesome. I plan on reviewing this later this week.

@andygrove
Copy link
Member

@rluvaton I think that this looks great but it is challenging to really review the PR with so many changes.

2025-01-03_11-20

What do you think about breaking this down into some smaller PRs that are easier to review? For example, maybe the first PR just moves string expressions.

@rluvaton
Copy link
Contributor Author

rluvaton commented Jan 5, 2025

No problem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants