Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[JDO-709] Enable Element.TYPE for @Convert - TCK test #61

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

[JDO-709] Enable Element.TYPE for @Convert - TCK test #61

wants to merge 4 commits into from

Conversation

tzaeschke
Copy link
Contributor

This PR is based on PR #60 . This PR adds @Convert tests to the PointAttributeConverterTest in the TCK.

The convertible point class is called ConvertiblePoint and is used in a new persistent class is PCRectPointTypeAnnotated.

Questions:

  • Does the converter or the convertible class need to be declared in one of the .jdo or .orm files?
  • Do we need to initialize the ConvertiblePoint fields in PCRectPointTypeAnnotated?

Current status: The test fails. It appears that the converter is not called.

  • Apparently the fields do not get initialized
  • Even when they are initialized, they don't appear to get stored/loaded.

dsid-converter-junit.txt

dsid-converter-tck.txt

Dieken and others added 4 commits October 26, 2022 11:36
@Dieken
[JDO-709] Enable Element.TYPE for @convert
c520553 
This reverts commit bddffab to be consistent with its javadoc.

With this capability, we can avoid as much configuration file as possible, it's very convenient
to mark default attribute converter for a type with Java annotation.

Reference: https://issues.apache.org/jira/browse/JDO-709?focusedCommentId=17619585&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17619585
@tzaeschke
Added TCK test
7594de0
@tzaeschke
Fixed tests
7234192
@tzaeschke
fixed formatting
beb21bf
@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 4, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 6 Code Smells

No Coverage information No Coverage information
11.5% 11.5% Duplication

@tzaeschke
Copy link
Contributor Author

I filed a ticket for the Datanucleus reference implementation: datanucleus/datanucleus-api-jdo#127

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tzaeschke @Dieken