Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update kubernetes java client to 19.0.0 and docker-java to 3.3.4 #15449

Merged

Conversation

janjwerner-confluent
Copy link
Contributor

@janjwerner-confluent janjwerner-confluent commented Nov 29, 2023

Description:

Update of direct dependencies:

  • kubernetes java-client to 19.0.0
  • docker-java-bom to 3.3.4

In order to update transitive dependencies:

  • okio to 3.6.0
  • bcjava to 1.76

To address CVES:

This PR has:

  • been self-reviewed.
  • added documentation for new or modified features or behaviors.
  • a release note entry in the PR description.
  • added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
  • added or updated version, license, or notice information in licenses.yaml
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
  • added integration tests.
  • been tested in a test Druid cluster.

@janjwerner-confluent janjwerner-confluent marked this pull request as draft November 30, 2023 22:57
@janjwerner
Copy link

The integration failure caused by the change of line 68:
re-reviewing the API docs
Caused by: org.apache.druid.java.util.common.RE: Failed to patch pod[default/druid-tiny-cluster-historicals-0], code[422], error[{ "kind": "Status", "apiVersion": "v1", "metadata": {}, "status": "Failure", "message": "PatchOptions.meta.k8s.io \"\" is invalid: force: Forbidden: may not be specified for non-apply patch", "reason": "Invalid", "details": { "group": "meta.k8s.io", "kind": "PatchOptions", "causes": [ { "reason": "FieldValueForbidden", "message": "Forbidden: may not be specified for non-apply patch", "field": "force" } ] },

@janjwerner-confluent
Copy link
Contributor Author

Given that the arguments are optional, I replaced the specific values with nulls. This let me stand up the cluster, now testing the change using ci/cd.

@janjwerner-confluent janjwerner-confluent marked this pull request as ready for review December 8, 2023 02:11
@janjwerner-confluent janjwerner-confluent changed the title update kubernetes java client to 19.0.0 update kubernetes java client to 19.0.0 and docker-java to 3.3.4 Dec 12, 2023
@xvrl xvrl merged commit 3c7dec5 into apache:master Dec 12, 2023
89 checks passed
Pankaj260100 pushed a commit to confluentinc/druid that referenced this pull request Dec 13, 2023
…che#15449)

Update of direct dependencies:
* kubernetes java-client to 19.0.0
* docker-java-bom to 3.3.4

In order to update transitive dependencies:
* okio to 3.6.0
* bcjava to 1.76

To address CVES:
- CVE-2023-3635 in okio
- CVE-2023-33201 in bcjava

---------

Co-authored-by: Xavier Léauté <[email protected]>
Pankaj260100 pushed a commit to confluentinc/druid that referenced this pull request Dec 19, 2023
…che#15449)

Update of direct dependencies:
* kubernetes java-client to 19.0.0
* docker-java-bom to 3.3.4

In order to update transitive dependencies:
* okio to 3.6.0
* bcjava to 1.76

To address CVES:
- CVE-2023-3635 in okio
- CVE-2023-33201 in bcjava

---------

Co-authored-by: Xavier Léauté <[email protected]>
Pankaj260100 pushed a commit to confluentinc/druid that referenced this pull request Dec 19, 2023
…che#15449)

Update of direct dependencies:
* kubernetes java-client to 19.0.0
* docker-java-bom to 3.3.4

In order to update transitive dependencies:
* okio to 3.6.0
* bcjava to 1.76

To address CVES:
- CVE-2023-3635 in okio
- CVE-2023-33201 in bcjava

---------

Co-authored-by: Xavier Léauté <[email protected]>
@LakshSingla LakshSingla added this to the 29.0.0 milestone Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants